Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postman: fix and add libuuid as dependency #91933

Merged
merged 1 commit into from Jul 7, 2020

Conversation

@ngerstle-cognite
Copy link
Contributor

ngerstle-cognite commented Jul 1, 2020

Motivation for this change

Postman is failing on NixOS:
/home/user/.nix-profile/bin/postman: error while loading shared libraries: libuuid.so.1: cannot open shared object file: No such file or directory

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

evanjs left a comment

I did not realize just how limited the suggestion interface is (I can't suggest edits on hunks not touched by the PR?)
Or maybe I'm just using it wrong :D

Anyway! Adding at-spi2-core (in addition to libuuid) to the arguments and buildInputs seems to get things running again.

Thank you!

pkgs/development/web/postman/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from evanjs Jul 6, 2020
@ngerstle-cognite ngerstle-cognite force-pushed the ngerstle-cognite:patch-1 branch from 5574dba to f56472d Jul 6, 2020
@DamienCassou
Copy link
Contributor

DamienCassou commented Jul 7, 2020

Result of nixpkgs-review pr 91933 1

1 package built:
- postman
@DamienCassou DamienCassou merged commit 8caac93 into NixOS:master Jul 7, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f56472d"; rev="f56472d93a02bbe83480a9282eaef8993f57bb74"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f56472d"; rev="f56472d93a02bbe83480a9282eaef8993f57bb74"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f56472d"; rev="f56472d93a02bbe83480a9282eaef8993f57bb74"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f56472d"; rev="f56472d93a02bbe83480a9282eaef8993f57bb74"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f56472d"; rev="f56472d93a02bbe83480a9282eaef8993f57bb74"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f56472d"; rev="f56472d93a02bbe83480a9282eaef8993f57bb74"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f56472d"; rev="f56472d93a02bbe83480a9282eaef8993f57bb74"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@DamienCassou
Copy link
Contributor

DamienCassou commented Jul 7, 2020

Thank you.

@ngerstle-cognite
Copy link
Contributor Author

ngerstle-cognite commented Jul 7, 2020

Thanks for merging!

@ngerstle-cognite ngerstle-cognite deleted the ngerstle-cognite:patch-1 branch Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.