Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joplin-desktop: 1.0.216 -> 1.0.233 #91948

Merged
merged 4 commits into from Aug 3, 2020
Merged

Conversation

@CheariX
Copy link
Contributor

CheariX commented Jul 1, 2020

Motivation for this change
  1. Joplin Update to 1.0.227. This release includes the new CodeMirror Editor.
  2. Security Fix CVE-2020-15844
  3. App Icon did not work. Fixed

Since I had no glue how to fix (2), i borrowed the idea from another nix package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@CheariX CheariX changed the title <!-- To help with the large amounts of pull requests, we would appreciate your reviews of other pull requests, especially simple package updates. Just leave a comment describing what you have tested in the relevant package/service. Reviewing helps to reduce the average time-to-merge for everyone. Thanks a lot if you do! List of open PRs: https://github.com/NixOS/nixpkgs/pulls Reviewing guidelines: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions --> joplin-desktop: 1.0.216 -> 1.0.224 Jul 1, 2020
@ofborg ofborg bot requested a review from HugoReeves Jul 2, 2020
Copy link
Member

HugoReeves left a comment

Built successfully on NixOS. LGTM

@CheariX
Copy link
Contributor Author

CheariX commented Jul 13, 2020

1.0.227 has been released. I added a commit for this

@ofborg ofborg bot requested a review from HugoReeves Jul 13, 2020
Copy link
Member

HugoReeves left a comment

I'm unable to build and test this right now but LGTM. Can be merged.

@CheariX CheariX changed the title joplin-desktop: 1.0.216 -> 1.0.224 joplin-desktop: 1.0.216 -> 1.0.227 Jul 14, 2020
@CheariX CheariX changed the title joplin-desktop: 1.0.216 -> 1.0.227 joplin-desktop: 1.0.216 -> 1.0.233 Aug 3, 2020
@ofborg ofborg bot requested a review from HugoReeves Aug 3, 2020
Copy link
Member

HugoReeves left a comment

LGTM

@Infinisil Infinisil merged commit 396c161 into NixOS:master Aug 3, 2020
18 checks passed
18 checks passed
tests tests
Details
tests
Details
joplin-desktop, joplin-desktop.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4ba054e"; rev="4ba054ee37f3e0befadc01aa8592373b7fb20654"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4ba054e"; rev="4ba054ee37f3e0befadc01aa8592373b7fb20654"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4ba054e"; rev="4ba054ee37f3e0befadc01aa8592373b7fb20654"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4ba054e"; rev="4ba054ee37f3e0befadc01aa8592373b7fb20654"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4ba054e"; rev="4ba054ee37f3e0befadc01aa8592373b7fb20654"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4ba054e"; rev="4ba054ee37f3e0befadc01aa8592373b7fb20654"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4ba054e"; rev="4ba054ee37f3e0befadc01aa8592373b7fb20654"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
joplin-desktop, joplin-desktop.passthru.tests on x86_64-linux Success
Details
@CheariX CheariX deleted the CheariX:joplin-desktop-1.0.224 branch Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.