Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc810x: remove obsolete overrides (3/x) #91950

Merged
merged 1 commit into from Jul 3, 2020

Conversation

@svmhdvn
Copy link
Contributor

svmhdvn commented Jul 1, 2020

Motivation for this change

Remove obsolete overrides on the following haskellPackages:

regex-pcre-builtin: -doJailbreak
regex-posix: -doJailbreak
regex-tdfa: -doJailbreak
split: -doJailbreak
tar: -doJailbreak

Part of #86500

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@svmhdvn svmhdvn requested a review from cdepillabout as a code owner Jul 1, 2020
@svmhdvn
Copy link
Contributor Author

svmhdvn commented Jul 1, 2020

@GrahamcOfBorg build haskell.packages.ghc8101.regex-pcre-builtin
@GrahamcOfBorg build haskell.packages.ghc8101.regex-posix
@GrahamcOfBorg build haskell.packages.ghc8101.regex-tdfa
@GrahamcOfBorg build haskell.packages.ghc8101.split
@GrahamcOfBorg build haskell.packages.ghc8101.tar

@cdepillabout
Copy link
Member

cdepillabout commented Jul 2, 2020

Ah sorry, looks like this PR conflicts with a previous one as well. If you fix this up I'd be happy to merge it in.

@svmhdvn
Copy link
Contributor Author

svmhdvn commented Jul 2, 2020

Will do, just waiting on #91945 so we don't run into another one.

@svmhdvn svmhdvn force-pushed the svmhdvn:ghc810x-o3 branch from e5d6fb8 to d405845 Jul 3, 2020
regex-pcre-builtin: -doJailbreak
regex-posix: -doJailbreak
regex-tdfa: -doJailbreak
split: -doJailbreak
tar: -doJailbreak
@svmhdvn svmhdvn force-pushed the svmhdvn:ghc810x-o3 branch from d405845 to 72f9a48 Jul 3, 2020
@svmhdvn
Copy link
Contributor Author

svmhdvn commented Jul 3, 2020

@GrahamcOfBorg build haskell.packages.ghc8101.regex-pcre-builtin
@GrahamcOfBorg build haskell.packages.ghc8101.regex-posix
@GrahamcOfBorg build haskell.packages.ghc8101.regex-tdfa
@GrahamcOfBorg build haskell.packages.ghc8101.split
@GrahamcOfBorg build haskell.packages.ghc8101.tar

@cdepillabout
Copy link
Member

cdepillabout commented Jul 3, 2020

Looks good, thanks for updating this one as well.

@cdepillabout cdepillabout merged commit 24d29a5 into NixOS:haskell-updates Jul 3, 2020
15 of 22 checks passed
15 of 22 checks passed
haskell.packages.ghc8101.regex-pcre-builtin on aarch64-linux
Details
haskell.packages.ghc8101.regex-posix on aarch64-linux
Details
haskell.packages.ghc8101.regex-tdfa on aarch64-linux
Details
haskell.packages.ghc8101.split on aarch64-linux
Details
haskell.packages.ghc8101.tar on aarch64-linux
Details
grahamcofborg-eval Calculating Changed Outputs
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="72f9a48"; rev="72f9a484715267d2cba54f0c5028c578fcca3579"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="72f9a48"; rev="72f9a484715267d2cba54f0c5028c578fcca3579"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="72f9a48"; rev="72f9a484715267d2cba54f0c5028c578fcca3579"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="72f9a48"; rev="72f9a484715267d2cba54f0c5028c578fcca3579"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="72f9a48"; rev="72f9a484715267d2cba54f0c5028c578fcca3579"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="72f9a48"; rev="72f9a484715267d2cba54f0c5028c578fcca3579"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="72f9a48"; rev="72f9a484715267d2cba54f0c5028c578fcca3579"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
haskell.packages.ghc8101.regex-pcre-builtin on x86_64-linux Success
Details
haskell.packages.ghc8101.regex-posix on x86_64-linux Success
Details
haskell.packages.ghc8101.regex-tdfa on x86_64-linux Success
Details
haskell.packages.ghc8101.split on x86_64-linux Success
Details
haskell.packages.ghc8101.tar on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.