Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc810x: remove obsolete overrides (4/x) #91951

Merged
merged 1 commit into from Jul 2, 2020

Conversation

@svmhdvn
Copy link
Contributor

svmhdvn commented Jul 1, 2020

Motivation for this change

Remove obsolete overrides on the following haskellPackages:

tasty-expected-failure: -doJailbreak
tasty-rerun: -doJailbreak
vector: -doJailbreak
zlib: -doJailbreak
aeson-diff: -doJailbreak

Part of #86500

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
tasty-expected-failure: -doJailbreak
tasty-rerun: -doJailbreak
vector: -doJailbreak
zlib: -doJailbreak
aeson-diff: -doJailbreak
@svmhdvn svmhdvn requested a review from cdepillabout as a code owner Jul 1, 2020
@svmhdvn
Copy link
Contributor Author

svmhdvn commented Jul 1, 2020

@GrahamcOfBorg build haskell.packages.ghc8101.tasty-expected-failure
@GrahamcOfBorg build haskell.packages.ghc8101.tasty-rerun
@GrahamcOfBorg build haskell.packages.ghc8101.vector
@GrahamcOfBorg build haskell.packages.ghc8101.zlib
@GrahamcOfBorg build haskell.packages.ghc8101.aeson-diff

@cdepillabout
Copy link
Member

cdepillabout commented Jul 2, 2020

Looks good, everything is building

@cdepillabout cdepillabout merged commit c391ffc into NixOS:haskell-updates Jul 2, 2020
8 of 10 checks passed
8 of 10 checks passed
haskell.packages.ghc8101.aeson-diff on aarch64-linux
Details
haskell.packages.ghc8101.tasty-expected-failure on aarch64-linux
Details
haskell.packages.ghc8101.tasty-rerun on aarch64-linux Timed out, unknown build status
Details
haskell.packages.ghc8101.vector on aarch64-linux Timed out, unknown build status
Details
haskell.packages.ghc8101.zlib on aarch64-linux Timed out, unknown build status
Details
haskell.packages.ghc8101.aeson-diff on x86_64-linux Success
Details
haskell.packages.ghc8101.tasty-expected-failure on x86_64-linux Success
Details
haskell.packages.ghc8101.tasty-rerun on x86_64-linux Success
Details
haskell.packages.ghc8101.vector on x86_64-linux Success
Details
haskell.packages.ghc8101.zlib on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.