Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sd-image: Add option to control sd image expansion on boot. #91955

Open
wants to merge 1 commit into
base: master
from

Conversation

@c00w
Copy link
Contributor

c00w commented Jul 1, 2020

This is super useful to allow the normal sd-image code to be used by
someone who wants to setup multiple partitions with a sd-image.

Currently I'm manually copying the sd-image file and modifying it
instead.

Tested by running

nix-build nixos -I nixos-config=nixos/modules/installer/cd-dvd/sd-image-aarch64.nix --argstr system
aarch64-linux -A config.system.build.sdImage

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
This is supeer useful to allow the normal sd-image code to be used by
someone who wants to setup multiple partitions with a sd-image.

Currently I'm manually copying the sd-image file and modifying it
instead.
@c00w c00w force-pushed the c00w:expand branch from 8295f9f to bab6700 Aug 2, 2020
@c00w
Copy link
Contributor Author

c00w commented Aug 2, 2020

@misuzu - done.

@samueldr - any chance you can review?

@misuzu
misuzu approved these changes Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.