Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telepathy-qt: 0.9.7 -> 0.9.8 #91957

Merged
merged 1 commit into from Jul 2, 2020
Merged

Conversation

@HenkKalkwater
Copy link
Contributor

HenkKalkwater commented Jul 1, 2020

Motivation for this change

Telepathy 0.9.8 has been out for quite some while.

  • telepathy 0.9.8 no longer supports Qt 4, so telepathy-qt and telepathy_qt now throw an error suggesting to use the Qt 5 packages instead.
  • telepathy 0.9.8 uses Python 3 instead of Python 2, so that has been corrected in the package.
  • telepathy 0.9.8 includes the patch that was previously manually added, so therefore it has been removed from the package.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
4 packages updated:
telepathy-qt (0.9.7 → 0.9.8) telepathy_qt (0.9.7 → 0.9.8) telepathy_qt5 (0.9.7 → 0.9.8) libsForQt5.telepathy (0.9.7 → 0.9.8)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@HenkKalkwater
Copy link
Contributor Author

HenkKalkwater commented Jul 1, 2020

It should also remove a duplicate callPackage, ticking one extra box for #39840

Copy link
Contributor

jonringer left a comment

LGTM

https://github.com/NixOS/nixpkgs/pull/91957
1 package built:
telepathy-qt

going to let more qt-savy people merge though
cc @worldofpeace @jtojnar

pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
* telepathy 0.9.8 no longer supports Qt 4, so telepathy-qt and
  telepathy_qt now throw an error suggesting to use the Qt 5 packages
  instead.
* telepathy 0.9.8 uses Python 3 instead of Python 2, so that has been
  corrected in the package.
* telepathy 0.9.8 includes the patch that was previously manually added,
  so therefore it is removed from the package.
@HenkKalkwater HenkKalkwater force-pushed the HenkKalkwater:fork/upgrade-telepathy branch from cce6aa4 to e2c7423 Jul 2, 2020
@HenkKalkwater HenkKalkwater requested a review from jtojnar Jul 2, 2020
@jtojnar jtojnar merged commit c1e2731 into NixOS:master Jul 2, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e2c7423"; rev="e2c742329f5d9d91c0bfd059452af92be3bb9016"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e2c7423"; rev="e2c742329f5d9d91c0bfd059452af92be3bb9016"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e2c7423"; rev="e2c742329f5d9d91c0bfd059452af92be3bb9016"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e2c7423"; rev="e2c742329f5d9d91c0bfd059452af92be3bb9016"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e2c7423"; rev="e2c742329f5d9d91c0bfd059452af92be3bb9016"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e2c7423"; rev="e2c742329f5d9d91c0bfd059452af92be3bb9016"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="e2c7423"; rev="e2c742329f5d9d91c0bfd059452af92be3bb9016"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jtojnar
Copy link
Contributor

jtojnar commented Jul 2, 2020

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.