Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keysmith: 0.1 → 0.2 #91961

Merged
merged 1 commit into from Nov 29, 2020
Merged

keysmith: 0.1 → 0.2 #91961

merged 1 commit into from Nov 29, 2020

Conversation

@SCOTT-HAMILTON
Copy link
Contributor

@SCOTT-HAMILTON SCOTT-HAMILTON commented Jul 1, 2020

Motivation for this change

Keysmith released a new stable tag

Things done

Moved from 0.1 to 0.2, this release brings a lot of new good features.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

@jonringer jonringer left a comment

doesn't work on nixos

QQmlApplicationEngine failed to load component
qrc:/main.qml:22 module "Oath" is not installed
qrc:/main.qml:23 module "Oath.Validators" is not installed
qrc:/main.qml:22 module "Oath" is not installed
qrc:/main.qml:23 module "Oath.Validators" is not installed

@SCOTT-HAMILTON
Copy link
Contributor Author

@SCOTT-HAMILTON SCOTT-HAMILTON commented Jul 1, 2020

I can't reproduce your error, this derivation runs fine for me.
Looking the sources, main.qml#L22-L23, I don't see what could produce this error : https://github.com/KDE/keysmith/blob/3880f325ce0730694daa6db868fac4c85462fa32/src/contents/ui/main.qml#L22

@SCOTT-HAMILTON
Copy link
Contributor Author

@SCOTT-HAMILTON SCOTT-HAMILTON commented Jul 4, 2020

Don't know why but using fetchurl rather than fetchFromGitHub fixed it.
Further examinating this behaviour, if I exrtact the source directly from the github archive, I don't get the issue anymore.
And obviously, the sources fetched by fetchFromGitHub and does manually fetched are identical.
The issue seems to come from fetchFromGitHub.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 8, 2020

:(

[nix-shell:/home/jon/.cache/nixpkgs-review/pr-91961]$ ./results//keysmith/bin/keysmith
QQmlApplicationEngine failed to load component
qrc:/main.qml:23 module "Oath.Validators" is not installed
qrc:/main.qml:22 module "Oath" is not installed
qrc:/main.qml:23 module "Oath.Validators" is not installed
qrc:/main.qml:22 module "Oath" is not installed

@SCOTT-HAMILTON
Copy link
Contributor Author

@SCOTT-HAMILTON SCOTT-HAMILTON commented Jul 9, 2020

Seems like I can't open issues upstream : https://github.com/KDE/keysmith

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Result of nixpkgs-review pr 91961 run on x86_64-linux 1

1 package built:
  • keysmith

@SuperSandro2000 SuperSandro2000 merged commit bfe757c into NixOS:master Nov 29, 2020
16 checks passed
16 checks passed
@ofborg[bot]
Evaluation Performance Report Evaluator Performance Report
Details
@ofborg[bot]
grahamcofborg-eval ^.^!
Details
@ofborg[bot]
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
@ofborg[bot]
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
@ofborg[bot]
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ebb18ac"; rev="ebb18acd825d5ef3f9cbe92e14a2d7d943047b1e"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
@ofborg[bot]
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ebb18ac"; rev="ebb18acd825d5ef3f9cbe92e14a2d7d943047b1e"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ebb18ac"; rev="ebb18acd825d5ef3f9cbe92e14a2d7d943047b1e"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ebb18ac"; rev="ebb18acd825d5ef3f9cbe92e14a2d7d943047b1e"; } ./nixos/
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ebb18ac"; rev="ebb18acd825d5ef3f9cbe92e14a2d7d943047b1e"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ebb18ac"; rev="ebb18acd825d5ef3f9cbe92e14a2d7d943047b1e"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ebb18ac"; rev="ebb18acd825d5ef3f9cbe92e14a2d7d943047b1e"; } ./pkgs/t
Details
@ofborg[bot]
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
@ofborg[bot]
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@ofborg[bot]
keysmith, keysmith.passthru.tests on aarch64-linux Success
Details
@ofborg[bot]
keysmith, keysmith.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants