Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.html-sanitizer init at 1.9.1 #91962

Merged
merged 1 commit into from Jul 1, 2020

Conversation

@colemickens
Copy link
Member

colemickens commented Jul 1, 2020

Motivation for this change

Initialize new python package, html-sanitizer. Needed for #84150 for Mirage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@colemickens colemickens requested review from FRidh and jonringer as code owners Jul 1, 2020
@colemickens
Copy link
Member Author

colemickens commented Jul 1, 2020

> nixpkgs-review rev 6f1cbf1
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
$ git worktree add /home/cole/.cache/nixpkgs-review/rev-6f1cbf1c393983a7fe17375c964726cc97462d75-1/nixpkgs 08df77da32b8adb91f45cbf0dd978fb9d46feaa7
Preparing worktree (detached HEAD 08df77da32b)
Updating files: 100% (22016/22016), done.
HEAD is now at 08df77da32b python3Packages.qasm2image: mark broken
$ nix-env -f /home/cole/.cache/nixpkgs-review/rev-6f1cbf1c393983a7fe17375c964726cc97462d75-1/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 6f1cbf1c393983a7fe17375c964726cc97462d75
Automatic merge went well; stopped before committing as requested
$ nix-env -f /home/cole/.cache/nixpkgs-review/rev-6f1cbf1c393983a7fe17375c964726cc97462d75-1/nixpkgs -qaP --xml --out-path --show-trace --meta
3 packages added:
python27Packages.html-sanitizer (init at 1.9.1) python37Packages.html-sanitizer (init at 1.9.1) python38Packages.html-sanitizer (init at 1.9.1)

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/cole/.cache/nixpkgs-review/rev-6f1cbf1c393983a7fe17375c964726cc97462d75-1/build.nix
3 packages built:
python27Packages.html-sanitizer python37Packages.html-sanitizer python38Packages.html-sanitizer

$ nix-shell /home/cole/.cache/nixpkgs-review/rev-6f1cbf1c393983a7fe17375c964726cc97462d75-1/shell.nix

[nix-shell:~/.cache/nixpkgs-review/rev-6f1cbf1c393983a7fe17375c964726cc97462d75-1]$
Copy link
Contributor

jonringer left a comment

diff LGTM
commits LGTM
has tests 👍

https://github.com/NixOS/nixpkgs/pull/91962
3 packages built:
python27Packages.html-sanitizer python37Packages.html-sanitizer python38Packages.html-sanitizer
@jonringer jonringer merged commit 85c5636 into NixOS:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.