Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.testfixtures: fix build (ignore failing tests) #91964

Merged
merged 1 commit into from Jul 4, 2020

Conversation

@siriobalmelli
Copy link
Contributor

siriobalmelli commented Jul 1, 2020

Signed-off-by: Sirio Balmelli sirio@b-ad.ch

Motivation for this change

Need testfixtures package as a dependency for pykwalify but it would fail build because of 2 tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

jonringer left a comment

otherwise LGTM

Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
Co-authored-by: Joh <jonringer@users.noreply.github.com>
@siriobalmelli siriobalmelli force-pushed the siriobalmelli-foss:fix/testfixtures branch from 71a0c34 to 75f8b1c Jul 4, 2020
Copy link
Contributor

jonringer left a comment

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/91964
5 packages failed to build:
python27Packages.praw python27Packages.prawcore python37Packages.sopel python38Packages.connexion python38Packages.sopel

19 packages built:
gitAndTools.bump2version python27Packages.testfixtures python37Packages.connexion python37Packages.django-simple-captcha python37Packages.praw python37Packages.prawcore python37Packages.scrapy python37Packages.scrapy-deltafetch python37Packages.scrapy-fake-useragent python37Packages.scrapy-splash python37Packages.testfixtures python38Packages.django-simple-captcha python38Packages.praw python38Packages.prawcore python38Packages.scrapy python38Packages.scrapy-deltafetch python38Packages.scrapy-fake-useragent python38Packages.scrapy-splash python38Packages.testfixtures
@jonringer jonringer merged commit f0c7019 into NixOS:master Jul 4, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75f8b1c"; rev="75f8b1c03b2673317c861965bf6ba64650622c72"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75f8b1c"; rev="75f8b1c03b2673317c861965bf6ba64650622c72"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75f8b1c"; rev="75f8b1c03b2673317c861965bf6ba64650622c72"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75f8b1c"; rev="75f8b1c03b2673317c861965bf6ba64650622c72"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75f8b1c"; rev="75f8b1c03b2673317c861965bf6ba64650622c72"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75f8b1c"; rev="75f8b1c03b2673317c861965bf6ba64650622c72"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="75f8b1c"; rev="75f8b1c03b2673317c861965bf6ba64650622c72"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@siriobalmelli siriobalmelli deleted the siriobalmelli-foss:fix/testfixtures branch Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.