Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update looking-glass-client to B2-rc2 #91969

Open
wants to merge 1 commit into
base: master
from

Conversation

@patrickod
Copy link

patrickod commented Jul 1, 2020

Motivation for this change

Update Looking Glass to B2-rc2 to take advantage of approximately a year worth of performance and feature improvements.

Things done
  • Set looking-glass-client version to B2-rc2.
  • Add libXi dependency to address compilation exception
  • Update fetchFromGitHub to fetch submodules introduced in recent versions.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
* Set looking-glass-client version to B2-rc2.
* Add libXi dependency to address compilation exception
* Update fetchFromGitHub to fetch submodules introduced in recent versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.