Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conan: 1.25.0 -> 1.27.0 & unbreak with six upgrade #91971

Merged
merged 2 commits into from Jul 1, 2020

Conversation

@drewrisinger
Copy link
Contributor

drewrisinger commented Jul 1, 2020

Motivation for this change

Fix #91959

  • updated conan to latest version
  • switched conan to fetch GitHub vs PyPi source
  • removed unused (pytest) & redundant (node-semver) python dependency packages
  • unpinned pythonPackages.six to fix #91959 (the only update is a faster six.ensure_str() method).
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
drewrisinger added 2 commits Jul 1, 2020
Switch to fetching source from GitHub vs PyPi, which will enable running
packaging tests in the future.
@drewrisinger drewrisinger requested a review from HaoZeke Jul 1, 2020
Copy link
Contributor

jonringer left a comment

LGTM

Result of nixpkgs-review pr 91971 1

1 package built:
- conan

@jonringer jonringer merged commit 2396eb6 into NixOS:master Jul 1, 2020
@drewrisinger drewrisinger deleted the drewrisinger:dr-fix-91959 branch Jul 1, 2020
Copy link
Member

HaoZeke left a comment

Thanks, looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.