Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runc: 1.0.0-rc90 -> 1.0.0-rc91 #91979

Merged
merged 2 commits into from Jul 5, 2020
Merged

runc: 1.0.0-rc90 -> 1.0.0-rc91 #91979

merged 2 commits into from Jul 5, 2020

Conversation

@zowoq
Copy link
Contributor

zowoq commented Jul 2, 2020

https://github.com/opencontainers/runc/releases/tag/v1.0.0-rc91

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Member

vdemeester left a comment

LGTM 🐯

Copy link
Member

saschagrunert left a comment

LGTM

@zowoq zowoq marked this pull request as draft Jul 2, 2020
@zowoq zowoq force-pushed the zowoq:runc branch from e932326 to ee7835e Jul 2, 2020
@zowoq zowoq marked this pull request as ready for review Jul 2, 2020
@zowoq zowoq dismissed adisbladis’s stale review Jul 2, 2020

reverted to buildGoPackage

@ofborg ofborg bot requested review from saschagrunert, adisbladis and vdemeester Jul 2, 2020
@zowoq
Copy link
Contributor Author

zowoq commented Jul 2, 2020

@ofborg test podman

@ofborg ofborg bot added the 6.topic: nixos label Jul 2, 2020
@bhipple
Copy link
Contributor

bhipple commented Jul 5, 2020

Result of nixpkgs-review pr 91979 1

6 packages built:
- buildah
- cri-o
- k3s
- podman
- runc
- udocker
@bhipple
bhipple approved these changes Jul 5, 2020
@bhipple bhipple merged commit f688b2b into NixOS:master Jul 5, 2020
17 checks passed
17 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1cf202"; rev="f1cf202dbbe3de6ee8f4fd8b40a5c61654aaa19d"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1cf202"; rev="f1cf202dbbe3de6ee8f4fd8b40a5c61654aaa19d"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1cf202"; rev="f1cf202dbbe3de6ee8f4fd8b40a5c61654aaa19d"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1cf202"; rev="f1cf202dbbe3de6ee8f4fd8b40a5c61654aaa19d"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1cf202"; rev="f1cf202dbbe3de6ee8f4fd8b40a5c61654aaa19d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1cf202"; rev="f1cf202dbbe3de6ee8f4fd8b40a5c61654aaa19d"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f1cf202"; rev="f1cf202dbbe3de6ee8f4fd8b40a5c61654aaa19d"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
runc, runc.passthru.tests on aarch64-linux Success
Details
runc, runc.passthru.tests on x86_64-darwin Success
Details
runc, runc.passthru.tests on x86_64-linux Success
Details
@zowoq zowoq deleted the zowoq:runc branch Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.