Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enlightenment: setuid missing path #91980

Merged
merged 1 commit into from Jul 6, 2020

Conversation

@bagnaram
Copy link
Contributor

bagnaram commented Jul 2, 2020

Motivation for this change

e_util_setuid has the path hardcoded for which applications it allows to execute using setuid bit.
This patch fixes Trying to rfkill unblock the bluetooth adapter failed dialogs that occur whenever ACPI awakes occur.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@bagnaram bagnaram changed the title enlightenment: setuid missing path WIP: enlightenment: setuid missing path Jul 2, 2020
@bagnaram bagnaram force-pushed the bagnaram:fix/enlightenment-setuid-patch branch 2 times, most recently from 01d24e7 to c766382 Jul 2, 2020
(add correct nix path to setuid utility)
@bagnaram bagnaram force-pushed the bagnaram:fix/enlightenment-setuid-patch branch from c766382 to f3d1a4f Jul 2, 2020
@bagnaram bagnaram changed the title WIP: enlightenment: setuid missing path enlightenment: setuid missing path Jul 2, 2020
@romildo
romildo approved these changes Jul 6, 2020
@romildo romildo merged commit fcb0630 into NixOS:master Jul 6, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3d1a4f"; rev="f3d1a4fe98da0cec187e7a7b3ebded34129dc88b"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3d1a4f"; rev="f3d1a4fe98da0cec187e7a7b3ebded34129dc88b"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3d1a4f"; rev="f3d1a4fe98da0cec187e7a7b3ebded34129dc88b"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3d1a4f"; rev="f3d1a4fe98da0cec187e7a7b3ebded34129dc88b"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3d1a4f"; rev="f3d1a4fe98da0cec187e7a7b3ebded34129dc88b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3d1a4f"; rev="f3d1a4fe98da0cec187e7a7b3ebded34129dc88b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f3d1a4f"; rev="f3d1a4fe98da0cec187e7a7b3ebded34129dc88b"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.