Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pygogo: init at 0.13.2 #91981

Merged
merged 2 commits into from Jul 13, 2020
Merged

Conversation

@drewrisinger
Copy link
Contributor

drewrisinger commented Jul 2, 2020

Motivation for this change

Add a useful python logging library/application.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@drewrisinger
Copy link
Contributor Author

drewrisinger commented Jul 13, 2020

@danieldk would you mind reviewing?

Copy link
Member

danieldk left a comment

nix-review PR fails with:

builder for '/nix/store/9rx0vab2k0pbj2al86kcfraxcv7nh95x-python2.7-pkutils-1.1.0.drv' failed with exit code 1; last 10 log lines:
      TypeError: Expected str or VersionInfo instance, but got <type 'unicode'>
  
  
  Name         Stmts   Miss  Cover
  --------------------------------
  pkutils.py      86     11    87%
  ----------------------------------------------------------------------
  Ran 12 tests in 0.020s
  
  FAILED (failures=3)
cannot build derivation '/nix/store/kd40g88p01m2g7kn339dirz54mhkvxi3-env.drv': 1 dependencies couldn't be built
pkgs/development/python-modules/pygogo/default.nix Outdated Show resolved Hide resolved
@drewrisinger drewrisinger force-pushed the drewrisinger:dr-pr-pygogo branch from 46ffcad to 33b43b9 Jul 13, 2020
@drewrisinger drewrisinger force-pushed the drewrisinger:dr-pr-pygogo branch from 33b43b9 to 3f764fa Jul 13, 2020
Copy link
Contributor

jonringer left a comment

LGTM

Result of nixpkgs-review pr 91981 1

4 packages built: - python37Packages.pkutils - python37Packages.pygogo - python38Packages.pkutils - python38Packages.pygogo

@jonringer jonringer merged commit 7e8d919 into NixOS:master Jul 13, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3f764fa"; rev="3f764fa604c38986bb865441c086c0c91f23354b"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3f764fa"; rev="3f764fa604c38986bb865441c086c0c91f23354b"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3f764fa"; rev="3f764fa604c38986bb865441c086c0c91f23354b"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3f764fa"; rev="3f764fa604c38986bb865441c086c0c91f23354b"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3f764fa"; rev="3f764fa604c38986bb865441c086c0c91f23354b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3f764fa"; rev="3f764fa604c38986bb865441c086c0c91f23354b"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="3f764fa"; rev="3f764fa604c38986bb865441c086c0c91f23354b"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@drewrisinger drewrisinger deleted the drewrisinger:dr-pr-pygogo branch Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.