Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.semver: 2.8.1 -> 2.10.2 #91982

Merged
merged 3 commits into from Jul 2, 2020
Merged

Conversation

@drewrisinger
Copy link
Contributor

drewrisinger commented Jul 2, 2020

Motivation for this change

Update pythonPackages.semver to latest version. Old version was almost 2 years old. Release notes: https://github.com/python-semver/python-semver/releases

  • Updates doc webpage
  • Bumps version
  • Update to new GitHub repo.
  • updates tests
  • formatting
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@drewrisinger drewrisinger requested a review from np Jul 2, 2020
drewrisinger added 2 commits Jul 2, 2020
Unpins some dependencies to unbreak. Removes unused python dependencies,
and corrects some dependency replacements
@drewrisinger drewrisinger marked this pull request as ready for review Jul 2, 2020
@drewrisinger drewrisinger requested review from FRidh and jonringer as code owners Jul 2, 2020
@drewrisinger
Copy link
Contributor Author

drewrisinger commented Jul 2, 2020

I took the liberty of unbreaking a few packages that came up in nix-review.

@@ -66,7 +66,8 @@ buildPythonPackage rec {
--replace "marshmallow>=2.18.0, <4.0.0" "marshmallow" \
--replace "PyJWT>=1.7.1" "PyJWT" \
--replace "Flask-SQLAlchemy>=2.4, <3" "Flask-SQLAlchemy" \
--replace "Flask-JWT-Extended>=3.18, <4" "Flask-JWT-Extended"
--replace "Flask-JWT-Extended>=3.18, <4" "Flask-JWT-Extended" \
--replace "Flask-Login>=0.3, <0.5" "Flask-Login"
'';

This comment has been minimized.

@bhipple

bhipple Jul 2, 2020 Contributor

Thanks so much for fixing this!

Resolves #89746

@bhipple
Copy link
Contributor

bhipple commented Jul 2, 2020

Result of nixpkgs-review pr 91982 1

21 packages built:
- apache-airflow (python37Packages.apache-airflow)
- keepkey_agent (python38Packages.keepkey_agent)
- ledger_agent (python38Packages.ledger_agent)
- python27Packages.prance
- python27Packages.semver
- python37Packages.apispec
- python37Packages.flask-appbuilder
- python37Packages.jupyter-repo2docker
- python37Packages.keepkey_agent
- python37Packages.ledger_agent
- python37Packages.libagent
- python37Packages.prance
- python37Packages.semver
- python37Packages.trezor_agent
- python38Packages.apispec
- python38Packages.flask-appbuilder
- python38Packages.jupyter-repo2docker
- python38Packages.libagent
- python38Packages.prance
- python38Packages.semver
- trezor_agent (python38Packages.trezor_agent)
@bhipple
bhipple approved these changes Jul 2, 2020
@bhipple bhipple merged commit a54cd1c into NixOS:master Jul 2, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
apache-airflow, apache-airflow.passthru.tests on aarch64-linux Success
Details
apache-airflow, apache-airflow.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4ab1c2b"; rev="4ab1c2b03293b055df0237c4d12391d3f4866e01"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4ab1c2b"; rev="4ab1c2b03293b055df0237c4d12391d3f4866e01"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4ab1c2b"; rev="4ab1c2b03293b055df0237c4d12391d3f4866e01"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4ab1c2b"; rev="4ab1c2b03293b055df0237c4d12391d3f4866e01"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4ab1c2b"; rev="4ab1c2b03293b055df0237c4d12391d3f4866e01"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4ab1c2b"; rev="4ab1c2b03293b055df0237c4d12391d3f4866e01"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4ab1c2b"; rev="4ab1c2b03293b055df0237c4d12391d3f4866e01"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@drewrisinger drewrisinger deleted the drewrisinger:dr-pr-semver-bump branch Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.