Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zstd: build programs and tests against the shared library #91984

Merged
merged 1 commit into from Jul 14, 2020

Conversation

@veprbl
Copy link
Member

veprbl commented Jul 2, 2020

Motivation for this change

7f76daa introduces a regression where cmake still exports zstd_static library, but the file doesn't exist anymore. In the discussion #90218 (comment) it was also pointed out that we are not testing the libraries that we are using.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@veprbl veprbl added this to WIP in Staging via automation Jul 2, 2020
@veprbl veprbl moved this from WIP to Needs review in Staging Jul 2, 2020
@veprbl veprbl requested review from vcunat and Ericson2314 Jul 2, 2020
@veprbl veprbl force-pushed the veprbl:pr/zstd_use_shared_lib branch from 2b1a9cc to f6ef3ac Jul 2, 2020
Staging automation moved this from Needs review to Ready Jul 2, 2020
@veprbl veprbl mentioned this pull request Jul 6, 2020
3 of 10 tasks complete
lopsided98 referenced this pull request Jul 6, 2020
@veprbl veprbl merged commit ac94f1a into NixOS:staging Jul 14, 2020
17 of 18 checks passed
17 of 18 checks passed
zstd, zstd.passthru.tests on x86_64-darwin
Details
zstd.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f6ef3ac"; rev="f6ef3ac294335434b233b587cc01df8f68b2bf21"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f6ef3ac"; rev="f6ef3ac294335434b233b587cc01df8f68b2bf21"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f6ef3ac"; rev="f6ef3ac294335434b233b587cc01df8f68b2bf21"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f6ef3ac"; rev="f6ef3ac294335434b233b587cc01df8f68b2bf21"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f6ef3ac"; rev="f6ef3ac294335434b233b587cc01df8f68b2bf21"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f6ef3ac"; rev="f6ef3ac294335434b233b587cc01df8f68b2bf21"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="f6ef3ac"; rev="f6ef3ac294335434b233b587cc01df8f68b2bf21"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
zstd, zstd.passthru.tests on aarch64-linux Success
Details
zstd, zstd.passthru.tests on x86_64-linux Success
Details
Staging automation moved this from Ready to Done Jul 14, 2020
@veprbl veprbl deleted the veprbl:pr/zstd_use_shared_lib branch Jul 14, 2020
@ludovicc
Copy link

ludovicc commented Jul 15, 2020

@veprbl I'd like some help to fix the build for arrow-cpp which fails on Darwin because of zstd (#93202)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.