Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] ceph: 14.2.9 -> 14.2.10 #91989

Merged
merged 1 commit into from Jul 2, 2020
Merged

Conversation

@srhb
Copy link
Contributor

srhb commented Jul 2, 2020

Add new dependency on rdkafka
Also removed now-obsolete cve patch as it's integrated already

(cherry picked from commit a1f6898)
Backport of #91919

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Add new dependency on rdkafka
Also removed now-obsolete cve patch as it's integrated already

(cherry picked from commit a1f6898)
Backport of #91919
@srhb
Copy link
Contributor Author

srhb commented Jul 2, 2020

@ofborg test ceph-single-node ceph-multi-node

@johanot
johanot approved these changes Jul 2, 2020
Copy link
Contributor

johanot left a comment

LGTM!

@srhb
Copy link
Contributor Author

srhb commented Jul 2, 2020

Hmm, just noticed sambaFull may still be failing here, and that went away on master after a rebase. Trying that here as well, but maybe 20.03 is missing something, investigating.

@srhb srhb marked this pull request as draft Jul 2, 2020
@srhb
Copy link
Contributor Author

srhb commented Jul 2, 2020

@ofborg build sambaFull

@srhb srhb marked this pull request as ready for review Jul 2, 2020
@srhb
Copy link
Contributor Author

srhb commented Jul 2, 2020

According to ofBorg, sambaFull is fine after the rebase. All good.

@srhb srhb merged commit 1af2655 into NixOS:release-20.03 Jul 2, 2020
19 checks passed
19 checks passed
sambaFull on aarch64-linux No attempt
Details
sambaFull on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b1a39c0"; rev="b1a39c0e846e911fcbf590ae92c46e9fcd2d46e0"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b1a39c0"; rev="b1a39c0e846e911fcbf590ae92c46e9fcd2d46e0"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b1a39c0"; rev="b1a39c0e846e911fcbf590ae92c46e9fcd2d46e0"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b1a39c0"; rev="b1a39c0e846e911fcbf590ae92c46e9fcd2d46e0"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b1a39c0"; rev="b1a39c0e846e911fcbf590ae92c46e9fcd2d46e0"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b1a39c0"; rev="b1a39c0e846e911fcbf590ae92c46e9fcd2d46e0"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b1a39c0"; rev="b1a39c0e846e911fcbf590ae92c46e9fcd2d46e0"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
sambaFull on x86_64-linux Success
Details
tests.ceph-multi-node, tests.ceph-single-node on aarch64-linux Success
Details
tests.ceph-multi-node, tests.ceph-single-node on x86_64-linux Success
Details
@srhb srhb deleted the srhb:backport-ceph-14.2.10 branch Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.