Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platformio: Add udev rules to package output #92000

Merged
merged 2 commits into from Jul 11, 2020
Merged

Conversation

@f4814
Copy link
Contributor

f4814 commented Jul 2, 2020

Motivation for this change

The udev rules shipped with platformio are not part of the package output. This is a follow up to #91679 (I'll close the PR when this gets merged)

Things done

Put the udev rules into $out/lib/udev/rules.d/99-platformio-udev.rules. This also adds a patch to change the default warning when the rules are not found to a more NixOS specific message.

Some things feel weird for me:
1.) Is calling fetchFromGitHub in multiple places with the same arguments considered good style? I could not think of a better way to do this.
2.) Is patching a appropriate way to inform about the usage of the udev rules?

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
f4814 added 2 commits Jun 29, 2020
This adds the sentence "On NixOS add the platformio package to
services.udev.packages" to the warning.
@flokli
flokli approved these changes Jul 11, 2020
@flokli flokli merged commit 0057be6 into NixOS:master Jul 11, 2020
16 checks passed
16 checks passed
platformio, platformio.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5ed47f3"; rev="5ed47f34e429a6d6f62867729b9f033e8fca12f2"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5ed47f3"; rev="5ed47f34e429a6d6f62867729b9f033e8fca12f2"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5ed47f3"; rev="5ed47f34e429a6d6f62867729b9f033e8fca12f2"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5ed47f3"; rev="5ed47f34e429a6d6f62867729b9f033e8fca12f2"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5ed47f3"; rev="5ed47f34e429a6d6f62867729b9f033e8fca12f2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5ed47f3"; rev="5ed47f34e429a6d6f62867729b9f033e8fca12f2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="5ed47f3"; rev="5ed47f34e429a6d6f62867729b9f033e8fca12f2"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
platformio, platformio.passthru.tests on x86_64-linux Success
Details
@flokli flokli mentioned this pull request Jul 11, 2020
4 of 10 tasks complete
@f4814 f4814 deleted the f4814:platformio-udev branch Jul 11, 2020
@makefu
Copy link
Contributor

makefu commented Jul 12, 2020

@f4814 great stuff, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.