Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulnix: 1.9.4 -> 1.9.6 #92001

Merged
merged 1 commit into from Jul 7, 2020
Merged

vulnix: 1.9.4 -> 1.9.6 #92001

merged 1 commit into from Jul 7, 2020

Conversation

@ckauhaus
Copy link
Contributor

ckauhaus commented Jul 2, 2020

Motivation for this change

vulnix: 1.9.4 -> 1.9.6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Ubuntu)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@lsix
lsix approved these changes Jul 2, 2020
Copy link
Member

lsix left a comment

Built and tested. All good for me.

pkgs/tools/security/vulnix/default.nix Outdated Show resolved Hide resolved
@Ma27 Ma27 mentioned this pull request Jul 2, 2020
7 of 10 tasks complete
pkgs/tools/security/vulnix/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/vulnix/default.nix Outdated Show resolved Hide resolved
@ckauhaus
Copy link
Contributor Author

ckauhaus commented Jul 3, 2020

reworking to PR...

@ckauhaus ckauhaus force-pushed the ckauhaus:vulnix-1.9.6 branch from 8f99737 to a37e62f Jul 3, 2020
@ckauhaus
Copy link
Contributor Author

ckauhaus commented Jul 3, 2020

better?

@ckauhaus ckauhaus force-pushed the ckauhaus:vulnix-1.9.6 branch from a37e62f to 9c81792 Jul 7, 2020
Copy link
Contributor

jonringer left a comment

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/92001
1 package built:
vulnix
@jonringer jonringer merged commit 711e47a into NixOS:master Jul 7, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c81792"; rev="9c81792dbe313b4d73fe82af27ca5cd1e7005794"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c81792"; rev="9c81792dbe313b4d73fe82af27ca5cd1e7005794"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c81792"; rev="9c81792dbe313b4d73fe82af27ca5cd1e7005794"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c81792"; rev="9c81792dbe313b4d73fe82af27ca5cd1e7005794"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c81792"; rev="9c81792dbe313b4d73fe82af27ca5cd1e7005794"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c81792"; rev="9c81792dbe313b4d73fe82af27ca5cd1e7005794"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9c81792"; rev="9c81792dbe313b4d73fe82af27ca5cd1e7005794"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
vulnix, vulnix.passthru.tests on aarch64-linux Success
Details
vulnix, vulnix.passthru.tests on x86_64-linux Success
Details
@ckauhaus ckauhaus deleted the ckauhaus:vulnix-1.9.6 branch Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.