Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whirlpool-gui: init at 0.10.1 #92009

Merged
merged 1 commit into from Jul 3, 2020
Merged

Conversation

@offlinehacker
Copy link
Contributor

offlinehacker commented Jul 2, 2020

Motivation for this change

Add whrilpool-gui app.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@offlinehacker offlinehacker requested a review from mmahut as a code owner Jul 2, 2020
@mmahut
Copy link
Member

mmahut commented Jul 3, 2020

Tested, works fine, thank you.

@mmahut mmahut merged commit 5ca432d into NixOS:master Jul 3, 2020
16 checks passed
16 checks passed
whirlpool-gui, whirlpool-gui.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89c5275"; rev="89c5275baf3e67a8a47ccdd6ef01121f24c00c3e"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89c5275"; rev="89c5275baf3e67a8a47ccdd6ef01121f24c00c3e"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89c5275"; rev="89c5275baf3e67a8a47ccdd6ef01121f24c00c3e"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89c5275"; rev="89c5275baf3e67a8a47ccdd6ef01121f24c00c3e"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89c5275"; rev="89c5275baf3e67a8a47ccdd6ef01121f24c00c3e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89c5275"; rev="89c5275baf3e67a8a47ccdd6ef01121f24c00c3e"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="89c5275"; rev="89c5275baf3e67a8a47ccdd6ef01121f24c00c3e"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
whirlpool-gui, whirlpool-gui.passthru.tests on x86_64-linux Success
Details
@offlinehacker
Copy link
Contributor Author

offlinehacker commented Jul 3, 2020

Hmm looks like I forgot to put homepage in quotes as is required according to rfc.

@mmahut
Copy link
Member

mmahut commented Jul 3, 2020

Hmm looks like I forgot to put homepage in quotes as is required according to rfc.

Yes, I did comment on it, but was not sure if it is already in RFC. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.