Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owncloud-client: add libsecret dependency #92046

Merged
merged 1 commit into from Jul 2, 2020

Conversation

@fabianhauser
Copy link
Contributor

fabianhauser commented Jul 2, 2020

The libsecret dependency is required to access secrets from the gnome keyring. (The same is included in the (nearly identical) nextcloud-client)

If possible, it would be great if we could backport this to 20.03.

Motivation for this change

I would like to use the account login from my gnome-keyring with the owncloud-client package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
The libsecret dependency is required to access secrets from the gnome keychain.
@das-g
Copy link
Member

das-g commented Jul 2, 2020

Result of nixpkgs-review pr 92046 1

1 package built:
- owncloudclient (owncloud-client)
@bjornfor bjornfor merged commit cf0552d into NixOS:master Jul 2, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4f276b8"; rev="4f276b8b3c956b9a1cffa281c36e277791f88c8c"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4f276b8"; rev="4f276b8b3c956b9a1cffa281c36e277791f88c8c"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4f276b8"; rev="4f276b8b3c956b9a1cffa281c36e277791f88c8c"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4f276b8"; rev="4f276b8b3c956b9a1cffa281c36e277791f88c8c"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4f276b8"; rev="4f276b8b3c956b9a1cffa281c36e277791f88c8c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4f276b8"; rev="4f276b8b3c956b9a1cffa281c36e277791f88c8c"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="4f276b8"; rev="4f276b8b3c956b9a1cffa281c36e277791f88c8c"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
owncloud-client, owncloud-client.passthru.tests on aarch64-linux Success
Details
owncloud-client, owncloud-client.passthru.tests on x86_64-linux Success
Details
@bjornfor
Copy link
Contributor

bjornfor commented Jul 2, 2020

Backported to release-20.03: cf0552d.

@fabianhauser fabianhauser deleted the fabianhauser:owncloud-libsecret branch Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.