Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab: 13.0.6-ee -> 13.1.2-ee #92057

Closed
wants to merge 1 commit into from
Closed

Conversation

@flokli
Copy link
Contributor

flokli commented Jul 2, 2020

Motivation for this change

https://about.gitlab.com/releases/2020/07/01/security-release-13-1-2-release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@flokli flokli requested review from talyz, globin and petabyteboy Jul 2, 2020
@ofborg ofborg bot requested a review from fpletz Jul 2, 2020
@flokli
Copy link
Contributor Author

flokli commented Jul 2, 2020

This currently fails with gitlab-shell:

# gitlab.com/gitlab-org/gitlab-shell/internal/handler
go/src/gitlab.com/gitlab-org/gitlab-shell/internal/handler/exec.go:94:55: cannot use grpccorrelation.StreamClientCorrelationInterceptor(grpccorrelation.WithClientName(executable.GitlabShell)) (type "gitlab.com/gitlab-org/labkit/vendor/google.golang.org/grpc".StreamClientInterceptor) as type "google.golang.org/grpc".StreamClientInterceptor in argument to "google.golang.org/grpc".WithStreamInterceptor
go/src/gitlab.com/gitlab-org/gitlab-shell/internal/handler/exec.go:99:54: cannot use grpccorrelation.UnaryClientCorrelationInterceptor(grpccorrelation.WithClientName(executable.GitlabShell)) (type "gitlab.com/gitlab-org/labkit/vendor/google.golang.org/grpc".UnaryClientInterceptor) as type "google.golang.org/grpc".UnaryClientInterceptor in argument to "google.golang.org/grpc".WithUnaryInterceptor
builder for '/nix/store/jra41xhmc53y68n9l6ir44zzwi0b8mdv-gitlab-shell-13.3.0.drv' failed with exit code 1
error: build of '/nix/store/jra41xhmc53y68n9l6ir44zzwi0b8mdv-gitlab-shell-13.3.0.drv' failed
@flokli flokli mentioned this pull request Jul 2, 2020
3 of 10 tasks complete
@flokli
Copy link
Contributor Author

flokli commented Jul 6, 2020

Closing this PR, as I won't be able to do this upgrade any time soon.

The security fix in #92060 should be sufficient, but getting to >=13.1.x needs to be tackled eventually…

@flokli flokli closed this Jul 6, 2020
@petabyteboy
Copy link
Member

petabyteboy commented Jul 6, 2020

Thanks for your efforts, I will test the security fix later today and merge if everything is okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.