Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazpaint: init at 7.1.3 #92284

Merged
merged 1 commit into from Aug 2, 2020
Merged

lazpaint: init at 7.1.3 #92284

merged 1 commit into from Aug 2, 2020

Conversation

@gnidorah
Copy link
Contributor

@gnidorah gnidorah commented Jul 4, 2020

Motivation for this change

LazPaint is a raster image editor with layers created with Lazarus. It can interoperate with other layered editors via OpenRaster format. It also imports Paint.NET files (with their layer structure). Also, it can import 3d objects in Wavefront (.obj) format.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@gnidorah gnidorah force-pushed the gnidorah:lazpaint branch from 50152bd to 7a16daf Jul 4, 2020
@stigtsp
stigtsp approved these changes Jul 7, 2020
Copy link
Member

@stigtsp stigtsp left a comment

Tested executable - drew a cat, and imported a teapot obj.

Looks good to me :-)

Result of nixpkgs-review pr 92284 1

1 package built:
- lazpaint
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Jul 12, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/221


buildInputs = [ pango cairo glib atk gtk2 libX11 gdk-pixbuf ];

NIX_LDFLAGS = "--as-needed -rpath ${lib.makeLibraryPath buildInputs}";

This comment has been minimized.

@Mic92

Mic92 Aug 2, 2020
Contributor

I suppose this is because our Lazarus build comes without a compiler wrapper?

This comment has been minimized.

@gnidorah

gnidorah Aug 2, 2020
Author Contributor

@Mic92 Looks like, lazarus needs some care

This comment has been minimized.

@Mic92

Mic92 Aug 2, 2020
Contributor

I don't think there is enough interest so. It's quite a niche.

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Aug 2, 2020

Result of nixpkgs-review pr 92284 1

1 package built:
- lazpaint
@Mic92 Mic92 merged commit b7d4411 into NixOS:master Aug 2, 2020
16 checks passed
16 checks passed
lazpaint, lazpaint.passthru.tests on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a16daf"; rev="7a16dafa072127c85e3519879dd7c8182a68c462"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a16daf"; rev="7a16dafa072127c85e3519879dd7c8182a68c462"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a16daf"; rev="7a16dafa072127c85e3519879dd7c8182a68c462"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a16daf"; rev="7a16dafa072127c85e3519879dd7c8182a68c462"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a16daf"; rev="7a16dafa072127c85e3519879dd7c8182a68c462"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a16daf"; rev="7a16dafa072127c85e3519879dd7c8182a68c462"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7a16daf"; rev="7a16dafa072127c85e3519879dd7c8182a68c462"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
lazpaint, lazpaint.passthru.tests on x86_64-linux Success
Details
@gnidorah
Copy link
Contributor Author

@gnidorah gnidorah commented Aug 2, 2020

@stigtsp @Mic92 Thank you!

@gnidorah gnidorah deleted the gnidorah:lazpaint branch Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.