Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnetCorePackages.sdk_3_1: 3.1.103 -> 3.1.301 #92659

Closed
wants to merge 1 commit into from

Conversation

@jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 7, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Jul 7, 2020

@GrahamcOfBorg build dotnetCorePackages.sdk_3_1

@jonringer jonringer force-pushed the bump-dotnet-sdk branch from a2f1a43 to 9faeda8 Jul 7, 2020
@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Jul 7, 2020

@GrahamcOfBorg build dotnetCorePackages.sdk_3_1

@jonringer
Copy link
Contributor Author

@jonringer jonringer commented Jul 13, 2020

2 regressions

https://github.com/NixOS/nixpkgs/pull/92659
2 packages failed to build:
python-language-server wasabibackend

1 package built:
dotnet-sdk_3

@mausch
Copy link
Contributor

@mausch mausch commented Oct 18, 2020

Superseded by #97803 , I think this can be closed now.

@jonringer jonringer closed this Oct 18, 2020
@jonringer jonringer deleted the bump-dotnet-sdk branch Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants