Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] audacity: fix hash for replaced release tarball #93020

Merged
merged 1 commit into from Jul 12, 2020
Merged

[20.03] audacity: fix hash for replaced release tarball #93020

merged 1 commit into from Jul 12, 2020

Conversation

yurkobb
Copy link
Contributor

@yurkobb yurkobb commented Jul 12, 2020

Initially the 2.3.3 release was based on the wrong commit by upstream,
later retagged (see 1). This resulted in Audacity
complaining it is an alpha release in nixos-20.03.

This commit changes the hash to the fixed upstream tarball.

Motivation for this change

Before:

$ audacity --version
Audacity v2.3.3-alpha-Jan  1 1970

After:

$ audacity --version
Audacity v2.3.3
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yurkobb
audacity: fix hash for replaced release tarball
38c0a59 
Initially the 2.3.3 release was based on the wrong commit by upstream,
later retagged (see [1]). This resulted in resulted in Audacity
complaining it is an alpha release.

This commit changes the hash to the fixed upstream tarball.

[1]: audacity/audacity#421
@yurkobb yurkobb changed the title audacity: fix hash for replaced release tarball [20.03] audacity: fix hash for replaced release tarball Jul 12, 2020
@ofborg ofborg bot requested a review from the-kenny July 12, 2020 20:50
@yurkobb yurkobb changed the base branch from nixos-20.03 to release-20.03 July 12, 2020 21:03
@worldofpeace worldofpeace merged commit 2f92f28 into NixOS:release-20.03 Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-kenny the-kenny Awaiting requested review from the-kenny

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yurkobb @worldofpeace