Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babashka: 0.0.97 -> 0.1.3 #93140

Closed

Conversation

@bennyandresen
Copy link
Contributor

@bennyandresen bennyandresen commented Jul 14, 2020

Motivation for this change

latest version

the latest versions of babashka require graalvm20 and therefor the dependency changed from graalvm8 (at major version 19) to graalvm11-ce (major version 20)

see #93139

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@bennyandresen bennyandresen changed the title Babashka update 0.1.3 babashka: 0.0.97 -> 0.1.3 Jul 14, 2020
@bennyandresen bennyandresen force-pushed the bennyandresen:babashka_update_0.1.3 branch 2 times, most recently from 38afc3c to 9af741f Jul 14, 2020
@bennyandresen
Copy link
Contributor Author

@bennyandresen bennyandresen commented Jul 14, 2020

Fixed the weird basing I did.

Please note that it has a hard dependency on the PR #93139

@jlesquembre
Copy link
Contributor

@jlesquembre jlesquembre commented Jul 14, 2020

Just want to mention that babashka releases include a static binary, originally created to work on Alpine, that seems to work on NixOS. I added it as an overlay to my nix config, and I have been using it for some weeks. I'd prefer to use the version from this PR, but in case it takes time to get merged, maybe someone else find it useful:

https://github.com/jlesquembre/dotfiles/blob/38f5915e91d842516f1b1024a9b6970d89d7ffa6/overlays/common/default.nix#L45-L61

@ludovicc
Copy link

@ludovicc ludovicc commented Jul 17, 2020

Failed to build on Darwin:

nix-shell -p nixpkgs-review --run "nixpkgs-review pr 93140"
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/93140/head:refs/nixpkgs-review/1
remote: Enumerating objects: 18, done.
remote: Counting objects: 100% (18/18), done.
remote: Compressing objects: 100% (5/5), done.
remote: Total 21 (delta 12), reused 14 (delta 12), pack-reused 3
Unpacking objects: 100% (21/21), 5.23 KiB | 357.00 KiB/s, done.
From https://github.com/NixOS/nixpkgs
   942b6411dae..bae6984c217  master               -> refs/nixpkgs-review/0
 + b93241d4086...9af741ffca1 refs/pull/93140/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /Users/lclaude/.cache/nixpkgs-review/pr-93140/nixpkgs bae6984c21787dea00e100abef0cd45b89392e5e
Preparing worktree (detached HEAD bae6984c217)
Updating files: 100% (22140/22140), done.
HEAD is now at bae6984c217 croc: 8.0.11 -> 8.0.12
$ nix-env -f /Users/lclaude/.cache/nixpkgs-review/pr-93140/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit 9af741ffca1178ae5a07f50cde593cd4451772e3
Automatic merge went well; stopped before committing as requested
$ nix-env -f /Users/lclaude/.cache/nixpkgs-review/pr-93140/nixpkgs -qaP --xml --out-path --show-trace --meta
error: while evaluating 'callPackageWith' at /Users/lclaude/.cache/nixpkgs-review/pr-93140/nixpkgs/lib/customisation.nix:117:35, called from /Users/lclaude/.cache/nixpkgs-review/pr-93140/nixpkgs/pkgs/top-level/all-packages.nix:9566:14:
while evaluating 'makeOverridable' at /Users/lclaude/.cache/nixpkgs-review/pr-93140/nixpkgs/lib/customisation.nix:67:24, called from /Users/lclaude/.cache/nixpkgs-review/pr-93140/nixpkgs/lib/customisation.nix:121:8:
anonymous function at /Users/lclaude/.cache/nixpkgs-review/pr-93140/nixpkgs/pkgs/development/interpreters/clojure/babashka.nix:1:1 called without required argument 'graalvm11-ce', at /Users/lclaude/.cache/nixpkgs-review/pr-93140/nixpkgs/lib/customisation.nix:69:16
babashka requires graalvm20 now and we don't have a source-package build
for that yet.

For now depend on graalvm11-ce
@bennyandresen bennyandresen force-pushed the bennyandresen:babashka_update_0.1.3 branch from 9af741f to 970a51d Jul 22, 2020
@bennyandresen
Copy link
Contributor Author

@bennyandresen bennyandresen commented Jul 22, 2020

I'm not glad about it, but yeah darwin is currently not supported. :-O

As soon as graalvm11-ce gains darwin as an additional platform, this package should work too.

@bennyandresen
Copy link
Contributor Author

@bennyandresen bennyandresen commented Oct 10, 2020

Waiting until graalvm11-ce exists.

@bennyandresen bennyandresen deleted the bennyandresen:babashka_update_0.1.3 branch Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.