Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dune-release: 1.3.3 → 1.4.0 #93168

Merged
merged 1 commit into from Aug 2, 2020
Merged

Conversation

@sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Jul 15, 2020

Motivation for this change

https://github.com/ocamllabs/dune-release/releases/tag/1.4.0

Things done

Required a bit of fiddling around to get the mdx tests to work, but seems good now. yes for some reason would complain about a broken pipe in the no_doc test which I couldn't reproduce outside of nix-build. Seems to be safe to just ignore by piping it to /dev/null which makes the output match up again. No idea what's causing this.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@sternenseemann
Copy link
Member Author

@sternenseemann sternenseemann commented Jul 15, 2020

@GrahamcOfBorg build dune-release

@vbgl
Copy link
Contributor

@vbgl vbgl commented Aug 2, 2020

@GrahamcOfBorg build ocamlPackages.dune-release

@vbgl vbgl merged commit b37f774 into NixOS:master Aug 2, 2020
20 of 21 checks passed
20 of 21 checks passed
ocamlPackages.dune-release on aarch64-linux
Details
dune-release on aarch64-linux Unexpected error: command failed with exit code 1
Details
dune-release, dune-release.passthru.tests on aarch64-linux Unexpected error: command failed with exit code 1
Details
Evaluation Performance Report Evaluator Performance Report
Details
dune-release on x86_64-linux Success
Details
dune-release, dune-release.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="22310ac"; rev="22310ac3074765dc007f59261fd4af43675a2c19"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="22310ac"; rev="22310ac3074765dc007f59261fd4af43675a2c19"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="22310ac"; rev="22310ac3074765dc007f59261fd4af43675a2c19"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="22310ac"; rev="22310ac3074765dc007f59261fd4af43675a2c19"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="22310ac"; rev="22310ac3074765dc007f59261fd4af43675a2c19"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="22310ac"; rev="22310ac3074765dc007f59261fd4af43675a2c19"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="22310ac"; rev="22310ac3074765dc007f59261fd4af43675a2c19"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
ocamlPackages.dune-release on x86_64-darwin Success
Details
ocamlPackages.dune-release on x86_64-linux Success
Details
@sternenseemann sternenseemann deleted the sternenseemann:dune-release-1.4.0 branch Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.