Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/dovecot: configure mailboxes for all processes #93201

Merged
merged 1 commit into from Oct 3, 2020

Conversation

@symphorien
Copy link
Member

@symphorien symphorien commented Jul 15, 2020

Notably fts plugins need them for fts_autoindex_exclude = \SomeFlag

the inbox namespace is not enclosed in protocol imap in Debian's default configuration either.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@symphorien
Copy link
Member Author

@symphorien symphorien commented Jul 15, 2020

cc @Ma27 because you touched mailboxes recently.

@symphorien
Copy link
Member Author

@symphorien symphorien commented Aug 5, 2020

cc @peti @rickynils @globin @fpletz maintainers of dovecot. I'd really like this fix in 20.09.

@symphorien
Copy link
Member Author

@symphorien symphorien commented Aug 12, 2020

/marvin opt-in

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Aug 12, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Aug 12, 2020
@symphorien
Copy link
Member Author

@symphorien symphorien commented Aug 12, 2020

/status needs_reviewer

@symphorien symphorien force-pushed the dovecot-namespace-mailbox branch from 0270cac to 20a1999 Aug 28, 2020
Notably fts plugins need them for fts_autoindex_exclude = \SomeFlag
@symphorien symphorien force-pushed the dovecot-namespace-mailbox branch from 20a1999 to 7200fde Aug 28, 2020
@symphorien
Copy link
Member Author

@symphorien symphorien commented Aug 28, 2020

I solved the merge conflict

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Sep 14, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/300

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Sep 30, 2020

@glittershark please review.

@marvin-mk2
Copy link

@marvin-mk2 marvin-mk2 bot commented Oct 3, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@peti
Copy link
Member

@peti peti commented Oct 3, 2020

I don't understand the implications of this change and therefore feel unqualified to review this PR.

@symphorien
Copy link
Member Author

@symphorien symphorien commented Oct 3, 2020

If some part of the configuration is enclosed in protocol imap it will only be read by processes which deal with imap.
So indexing process won't read them. But one can exclude folders from being index by spcialuse. If the special use is enclosed in protocol imap it will be as if no folder has any special use flag, which precludes the configuration from working properly.

@gebner
Copy link
Member

@gebner gebner commented Oct 3, 2020

The services.dovecot2.mailboxes option is not set by default, so this shouldn't affect too many people.

@gebner gebner merged commit f26dcb4 into NixOS:master Oct 3, 2020
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants