Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edukai: init at 4.0/edusong: init at 1.0/eduli: init at 3.0 #93232

Merged
merged 3 commits into from Aug 1, 2020

Conversation

@ShamrockLee
Copy link
Contributor

ShamrockLee commented Jul 16, 2020

Motivation for this change

These fonts are distributed by the Ministry of Education, Republic of China (Taiwan) under CC BY-ND 3.0.

The MOE Standard Kai Font (教育部標準楷書字形檔) and the MOE Standard Song Font (教育部標準宋體字形檔) follow the standard ("國字標準字體研訂原則") of the Ministry of Education in Taiwan. They would be useful in test sheets, especially when the commercial DFKai-SB (標楷體) is not available.

The MOE Li Font (教育部隸書字形檔) is a piece of font of clerical script (an archaic style of Chinese calligraphy). If merged, it would probably become the first clerical font in nixpkgs.

I join them into one PR to avoid conflicts in all-packages.nix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) (No execution files)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date (No document change needed)
  • Fits CONTRIBUTING.md.
@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Jul 16, 2020

/marvin opt-in

@ShamrockLee ShamrockLee force-pushed the ShamrockLee:edukai branch 2 times, most recently from a10c1f7 to b1404d1 Jul 16, 2020
@ShamrockLee ShamrockLee force-pushed the ShamrockLee:edukai branch from b1404d1 to 928b63c Jul 28, 2020
@ofborg ofborg bot removed the 10.rebuild-linux: 1 label Jul 28, 2020
@ShamrockLee ShamrockLee force-pushed the ShamrockLee:edukai branch from 928b63c to 1f85176 Jul 28, 2020
@ShamrockLee ShamrockLee changed the title edukai: Init at 4.0 edukai: init at 4.0/edusong: init at 1.0/eduli: init at 3.0 Jul 28, 2020
@ShamrockLee ShamrockLee force-pushed the ShamrockLee:edukai branch from 1f85176 to 0a5b108 Jul 28, 2020
@nixos-discourse
Copy link

nixos-discourse commented Jul 28, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/233

@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Jul 30, 2020

/marvin opt-in

@marvin-mk2 marvin-mk2 bot added the marvin label Jul 30, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 30, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Jul 30, 2020

/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the needs_reviewer label Jul 30, 2020
@Infinisil
Copy link
Member

Infinisil commented Jul 30, 2020

Trying to connect to a homepage of the packages I get

Secure Connection Failed

An error occurred during a connection to language.moe.gov.tw. Cannot communicate securely with peer: no common encryption algorithm(s).

Error code: SSL_ERROR_NO_CYPHER_OVERLAP

So I propose to use HTTP instead of HTTPS for these links instead (both for the homepage and the download URL)

pkgs/data/fonts/edukai/default.nix Outdated Show resolved Hide resolved
@nixos-discourse
Copy link

nixos-discourse commented Jul 31, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/guidelines-on-packaging-fonts/7683/4

@ShamrockLee ShamrockLee force-pushed the ShamrockLee:edukai branch from 0a5b108 to 8a4d2b9 Jul 31, 2020
@ShamrockLee ShamrockLee requested a review from Infinisil Jul 31, 2020
@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Jul 31, 2020

/status awaiting_reviewer

@Infinisil
Copy link
Member

Infinisil commented Jul 31, 2020

See also #93232 (comment)

ShamrockLee added 3 commits Jun 29, 2020
Add `edukai` (MOE Standard Kai Font) version 4.0
If approved, users will be able to install
the Standard Chinese Kai Font provided by
the Ministry of Education, Republic of China (Taiwan).
Add `edusong` (MOE Standard Song Font)
If approved, users will be able to install
the Standard Chinese Song Font provided by
the Ministry of Education, Republic of China (Taiwan).
Add `eduli` (MOE Li Font)
If approved, users will be able to install
the Chinese Li (clerical) Font provided by
the Ministry of Education, Republic of China (Taiwan).
This is probably the first font of clerical script in nixpkgs.
@ShamrockLee ShamrockLee force-pushed the ShamrockLee:edukai branch from 8a4d2b9 to b2872b9 Aug 1, 2020
@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Aug 1, 2020

See also #93232 (comment)

Oops! Thanks for reminding.
@Infinisil I have them corrected.

Copy link
Member

Infinisil left a comment

Looking good!

@Infinisil Infinisil merged commit f9c2da7 into NixOS:master Aug 1, 2020
16 checks passed
16 checks passed
edukai, edukai.passthru.tests, eduli, eduli.passthru.tests, edusong, edusong.passthru.tests on aarch64-linux No attempt
Details
edukai, edukai.passthru.tests, eduli, eduli.passthru.tests, edusong, edusong.passthru.tests on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b2872b9"; rev="b2872b921d02b7da9d46b272d5a27cc672267528"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b2872b9"; rev="b2872b921d02b7da9d46b272d5a27cc672267528"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b2872b9"; rev="b2872b921d02b7da9d46b272d5a27cc672267528"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b2872b9"; rev="b2872b921d02b7da9d46b272d5a27cc672267528"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b2872b9"; rev="b2872b921d02b7da9d46b272d5a27cc672267528"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b2872b9"; rev="b2872b921d02b7da9d46b272d5a27cc672267528"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="b2872b9"; rev="b2872b921d02b7da9d46b272d5a27cc672267528"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.