Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netdata: 1.23.0 -> 1.23.2 #93274

Merged
merged 1 commit into from Aug 6, 2020
Merged

netdata: 1.23.0 -> 1.23.2 #93274

merged 1 commit into from Aug 6, 2020

Conversation

@RaghavSood
Copy link
Contributor

RaghavSood commented Jul 16, 2020

Motivation for this change

Upstream has a new version. Fixes a buffer overflow that could cause crashes and/or arbitrary code execution.

This supersedes and closes #92722.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ludovicc
Copy link

ludovicc commented Jul 16, 2020

Failed to biuld on Darwin:

builder for '/nix/store/f7kdl9513absm3icf4904krf0dlbb8dm-netdata-1.23.2.drv' failed with exit code 2; last 10 log lines:
  Undefined symbols for architecture x86_64:
    "_mempcpy", referenced from:
        _aclk_stats_main_thread in aclk_stats.o
  ld: symbol(s) not found for architecture x86_64
  clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
  make[2]: *** [Makefile:4327: netdata] Error 1
  make[2]: Leaving directory '/private/var/folders/v5/83p3n3f546nc81syhhrfs9mr0000gn/T/nix-build-netdata-1.23.2.drv-0/source'
  make[1]: *** [Makefile:5460: all-recursive] Error 1
  make[1]: Leaving directory '/private/var/folders/v5/83p3n3f546nc81syhhrfs9mr0000gn/T/nix-build-netdata-1.23.2.drv-0/source'
  make: *** [Makefile:2947: all] Error 2
cannot build derivation '/nix/store/mcxvg56vncl1zmpk2ahw1mqwcs6pfw6y-env.drv': 1 dependencies couldn't be built
[1 built (1 failed), 22 copied (38.8 MiB), 7.6 MiB DL]
error: build of '/nix/store/mcxvg56vncl1zmpk2ahw1mqwcs6pfw6y-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/93274
1 package failed to build:
netdata

@mweinelt mweinelt mentioned this pull request Jul 23, 2020
5 of 10 tasks complete
@marsam marsam force-pushed the RaghavSood:netdata/1.23.2 branch from 02db056 to 2ec6f07 Aug 6, 2020
@marsam marsam merged commit a52725d into NixOS:master Aug 6, 2020
18 checks passed
18 checks passed
tests tests
Details
tests
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2ec6f07"; rev="2ec6f070aa07a4c280d7b8ad3c87815078126240"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2ec6f07"; rev="2ec6f070aa07a4c280d7b8ad3c87815078126240"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2ec6f07"; rev="2ec6f070aa07a4c280d7b8ad3c87815078126240"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2ec6f07"; rev="2ec6f070aa07a4c280d7b8ad3c87815078126240"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2ec6f07"; rev="2ec6f070aa07a4c280d7b8ad3c87815078126240"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2ec6f07"; rev="2ec6f070aa07a4c280d7b8ad3c87815078126240"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="2ec6f07"; rev="2ec6f070aa07a4c280d7b8ad3c87815078126240"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
netdata, netdata.passthru.tests on aarch64-linux Success
Details
netdata, netdata.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.