Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

julia: Remove version 0.7 and 1.1 #93333

Merged
merged 3 commits into from Oct 18, 2020
Merged

julia: Remove version 0.7 and 1.1 #93333

merged 3 commits into from Oct 18, 2020

Conversation

@rht
Copy link
Member

@rht rht commented Jul 17, 2020

Motivation for this change

Everyone using 0.7 are strongly recommended to switch to 1.0 LTS. 1.1 can be removed because there is already 1.3, and 1.1 is not an LTS.

Things done

N/A

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@rht
Copy link
Member Author

@rht rht commented Jul 17, 2020

See #91930.

@rht
Copy link
Member Author

@rht rht commented Jul 17, 2020

Since there is already 1.3. Then 1.1 should be removed as well.

@rht
Copy link
Member Author

@rht rht commented Jul 17, 2020

@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Jul 17, 2020

@rht rht changed the title julia: Remove version 0.7 julia: Remove version 0.7 and 1.1 Jul 18, 2020
@garrison
Copy link
Member

@garrison garrison commented Sep 2, 2020

Bump. Could somebody please merge this, or else provide a path forward of what must happen first?

@rht
Copy link
Member Author

@rht rht commented Sep 2, 2020

cc: @7c6f434c

@ptrhlm
Copy link
Contributor

@ptrhlm ptrhlm commented Sep 14, 2020

This pull request would help with Zero Hydra Failures: #97479, as these packages are currently broken

Copy link
Contributor

@jonringer jonringer left a comment

builds are broken

$ nix build -f . julia_07 julia_11
error: build of '/nix/store/y0w7plv6ziqzypxw4rqdmdksmsxry90w-julia-0.7.0.drv' on 'ssh://build' failed: builder for '/nix/store/y0w7plv6ziqzypxw4rqdmdksmsxry90w-julia-0.7.0.drv' failed with exit code 2
builder for '/nix/store/y0w7plv6ziqzypxw4rqdmdksmsxry90w-julia-0.7.0.drv' failed with exit code 1; last 10 log lines:
    ProcessExitedException()
  Error in testset channels:
  Test Failed at /build/source/test/channels.jl:261
    Expression: isempty(Base.Workqueue)
  ERROR: LoadError: Test run finished with errors
  in expression starting at /build/source/test/runtests.jl:61
  make[1]: *** [Makefile:22: all] Error 1
  make[1]: Leaving directory '/build/source/test'
  make: *** [Makefile:580: testall] Error 2
  builder for '/nix/store/y0w7plv6ziqzypxw4rqdmdksmsxry90w-julia-0.7.0.drv' failed with exit code 2
[0 built (1 failed), 26 copied (276.0 MiB), 101.0 MiB DL]
error: build of '/nix/store/ri1mi3kk10cd29akhwlyd5mxjyi5b3a9-julia-1.1.1.drv', '/nix/store/y0w7plv6ziqzypxw4rqdmdksmsxry90w-julia-0.7.0.drv' failed

do you mind adding 2 entries in pkgs/top-level/alias.nix which declare that the packages were removed

zabbix example

  # added 2020-08-17
  zabbix44 = throw "Zabbix 4.4 is end of life, see https://www.zabbix.com/documentation/current/manual/installation/upgrade_notes_500 for details on upgrading to Zabbix 5.0.";
@NobbZ
Copy link
Contributor

@NobbZ NobbZ commented Sep 15, 2020

builds are broken

IIRC all julia builds are broken, due to failing tests. Would it make sense to doCheck = false to all of them?

rht added 3 commits Jul 17, 2020
@rht rht force-pushed the rht:master branch from aa447e9 to d36663c Sep 15, 2020
@rht
Copy link
Member Author

@rht rht commented Sep 15, 2020

@jonringer I added the deprecation notice.

@jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 15, 2020

builds are broken

IIRC all julia builds are broken, due to failing tests. Would it make sense to doCheck = false to all of them?

I think regardless if it were building, we would still want to remove EOL versions

@doronbehar doronbehar mentioned this pull request Sep 15, 2020
0 of 10 tasks complete
@doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Sep 15, 2020

I'm experimenting a more broad change to the situation at #98043 . There, only the derivations julia_lts and julia will be left, and hopefully they will build at some point, with most of our deps used instead of upstream's.

vcunat added a commit that referenced this pull request Oct 18, 2020
(cherry picked from commit 04821fb)
@vcunat vcunat merged commit 04821fb into NixOS:master Oct 18, 2020
18 checks passed
18 checks passed
tests tests
Details
action
Details
julia, julia.passthru.tests on aarch64-linux No attempt
Details
julia, julia.passthru.tests on x86_64-linux Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d36663c"; rev="d36663c84ef4fb127e65ce145e88fd1adc85f524"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d36663c"; rev="d36663c84ef4fb127e65ce145e88fd1adc85f524"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d36663c"; rev="d36663c84ef4fb127e65ce145e88fd1adc85f524"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d36663c"; rev="d36663c84ef4fb127e65ce145e88fd1adc85f524"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d36663c"; rev="d36663c84ef4fb127e65ce145e88fd1adc85f524"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d36663c"; rev="d36663c84ef4fb127e65ce145e88fd1adc85f524"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="d36663c"; rev="d36663c84ef4fb127e65ce145e88fd1adc85f524"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.