Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/gitlab: Support pages #93426

Merged
merged 1 commit into from Oct 11, 2020
Merged

Conversation

@dasJ
Copy link
Member

@dasJ dasJ commented Jul 18, 2020

Motivation for this change

Closes #84525

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@dasJ dasJ force-pushed the feat/gitlab-pages branch from f2bfb2a to f62e3da Jul 18, 2020
@dasJ dasJ force-pushed the feat/gitlab-pages branch from f62e3da to a852cc1 Jul 18, 2020
@dasJ
Copy link
Member Author

@dasJ dasJ commented Jul 18, 2020

@GrahamcOfBorg build gitlab-pages

@dasJ dasJ changed the title Feat/gitlab pages nixos/gitlab: Support pages Jul 18, 2020
@dali99
Copy link
Member

@dali99 dali99 commented Jul 19, 2020

fixes #84525

@dasJ dasJ requested a review from flokli Aug 21, 2020
@dasJ
Copy link
Member Author

@dasJ dasJ commented Aug 21, 2020

@dasJ dasJ force-pushed the feat/gitlab-pages branch from a852cc1 to 946b039 Aug 26, 2020
ajs124
ajs124 approved these changes Oct 5, 2020
@flokli flokli merged commit a6fec75 into NixOS:master Oct 11, 2020
17 checks passed
@ajs124 ajs124 deleted the feat/gitlab-pages branch Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment