Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update friture to master branch, add necessary python packages #93543

Merged
merged 4 commits into from Sep 7, 2020

Conversation

@laikq
Copy link
Contributor

@laikq laikq commented Jul 20, 2020

Motivation for this change

Package upgrade. I didn't upgrade to v0.41 because there were two issues with it that broke the package.

I didn't run tests for the python packages added with these commits, but friture seems to be able to use them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
pkgs/applications/audio/friture/default.nix Outdated Show resolved Hide resolved

meta = {
description = "Reliable low-latency audio playback and recording with Python, using PortAudio via the sounddevice module";
homepage = "https://python-rtmixer.readthedocs.io/en/0.1.1/";

This comment has been minimized.

@jonringer

jonringer Jul 22, 2020
Contributor

please add license

@laikq laikq force-pushed the laikq:friture_from_src branch from 25056e7 to 4d90922 Jul 25, 2020
@laikq
Copy link
Contributor Author

@laikq laikq commented Jul 25, 2020

Ahoy, I added the licenses and changed the date format. Also, I removed the fetchpatch derivation argument from friture (because it was just a development relict).

Copy link
Member

@Infinisil Infinisil left a comment

Other than these nits this looks good!

@laikq laikq force-pushed the laikq:friture_from_src branch 2 times, most recently from 428792a to 81d1743 Sep 3, 2020
@laikq
Copy link
Contributor Author

@laikq laikq commented Sep 3, 2020

This should do the trick!

Copy link
Contributor

@jonringer jonringer left a comment

  ERROR: sounddevice-0.4.0-py3-none-any.whl is not a supported wheel on this platform.
  builder for '/nix/store/594mvbqv48mlkmsm93m5bijkkkdv2g3s-python2.7-sounddevice-0.4.0.drv' failed with exit code 1
warning: SQLite database '/nix/var/nix/db/db.sqlite' is busy
cannot build derivation '/nix/store/g0q3l4gqzilpziak6akvcm8mf4rqhhwz-python2.7-rtmixer-0.1.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/1q5vzybkxdqvvgh1qi8gzj25pdbqbcw4-env.drv': 1 dependencies couldn't be built
@laikq laikq force-pushed the laikq:friture_from_src branch from 81d1743 to 7b29766 Sep 6, 2020
Copy link
Contributor

@jonringer jonringer left a comment

LGTM

Result of nixpkgs-review pr 93543 1

9 packages built:
  • friture
  • python27Packages.pa-ringbuffer
  • python27Packages.pyopengl-accelerate
  • python37Packages.pa-ringbuffer
  • python37Packages.pyopengl-accelerate
  • python37Packages.rtmixer
  • python38Packages.pa-ringbuffer
  • python38Packages.pyopengl-accelerate
  • python38Packages.rtmixer

@jonringer jonringer merged commit 1ee6812 into NixOS:master Sep 7, 2020
19 checks passed
19 checks passed
tests tests
Details
action
Details
Evaluation Performance Report Evaluator Performance Report
Details
Wait for ofborg
Details
friture, friture.passthru.tests, python, python.passthru.tests on aarch64-linux Success
Details
friture, friture.passthru.tests, python, python.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b29766"; rev="7b297662e344195d30daae6b3086b7ea38a41ea6"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b29766"; rev="7b297662e344195d30daae6b3086b7ea38a41ea6"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b29766"; rev="7b297662e344195d30daae6b3086b7ea38a41ea6"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b29766"; rev="7b297662e344195d30daae6b3086b7ea38a41ea6"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b29766"; rev="7b297662e344195d30daae6b3086b7ea38a41ea6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b29766"; rev="7b297662e344195d30daae6b3086b7ea38a41ea6"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="7b29766"; rev="7b297662e344195d30daae6b3086b7ea38a41ea6"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.