Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimplugins: Update default branch for tslime.vim #93686

Merged
merged 1 commit into from Aug 2, 2020

Conversation

@pseudomuto
Copy link
Contributor

@pseudomuto pseudomuto commented Jul 23, 2020

Motivation for this change

Unable to add new vim plugins due to the fact that the default branch for tslime.vim changed from master to main.

Things done

Updated the branch manually in vim-plugin-names and verified that ./update.py succeeded after.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@pseudomuto pseudomuto requested a review from jonringer as a code owner Jul 23, 2020
@pseudomuto pseudomuto changed the title Update default branch for tslime.vim vimplugins: Update default branch for tslime.vim Jul 23, 2020
Copy link
Contributor

@jonringer jonringer left a comment

Seems I'm unable to update the current vim plugin list without this

@jonringer jonringer merged commit b0d334f into NixOS:master Aug 2, 2020
13 checks passed
13 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0fd8a6d"; rev="0fd8a6dcafcde2512eb1adb4a5058edcfbf4e9bd"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0fd8a6d"; rev="0fd8a6dcafcde2512eb1adb4a5058edcfbf4e9bd"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0fd8a6d"; rev="0fd8a6dcafcde2512eb1adb4a5058edcfbf4e9bd"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0fd8a6d"; rev="0fd8a6dcafcde2512eb1adb4a5058edcfbf4e9bd"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0fd8a6d"; rev="0fd8a6dcafcde2512eb1adb4a5058edcfbf4e9bd"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0fd8a6d"; rev="0fd8a6dcafcde2512eb1adb4a5058edcfbf4e9bd"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="0fd8a6d"; rev="0fd8a6dcafcde2512eb1adb4a5058edcfbf4e9bd"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 2, 2020

@pseudomuto thanks for opening your first PR to nixpkgs :). Unfortunately, you caught me during vacation.

@jonringer jonringer mentioned this pull request Aug 2, 2020
5 of 10 tasks complete
@pseudomuto pseudomuto deleted the pseudomuto:vimplugins_tslime_fix branch Aug 4, 2020
@pseudomuto pseudomuto mentioned this pull request Aug 4, 2020
0 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.