Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oneDNN: compile without -msse4.1 #93747

Merged
merged 1 commit into from Jul 25, 2020
Merged

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Jul 24, 2020

Motivation for this change

Follow-up to #93692. I think I have found the culprit. According to

https://logs.nix.samueldr.com/nixos-dev/2019-03-09#2025618;

ike is a 6100 series Opteron, which does not support SSE 4.1:

https://en.wikipedia.org/wiki/List_of_AMD_Opteron_microprocessors#Opteron_6100-series_%22Magny-Cours%22_(45_nm)

oneDNN adds -msse4.1 by default. This PR removes architecture optimization flags.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk danieldk merged commit fdbae69 into NixOS:master Jul 25, 2020
@danieldk danieldk deleted the onednn-no-sse4.1 branch July 25, 2020 11:36
@marsam
Copy link
Contributor

marsam commented Jul 26, 2020

@danieldk thanks for following up on this

@danieldk
Copy link
Contributor Author

Hmpf. We seem to get further, but still no dice:

https://hydra.nixos.org/build/124427154/nixlog/1

Now 9/101 tests fail. It seems that OneDNN is really not tested by upstream on machines without SSE4.1. The problem is that every time this gets built on ike (or another older Hydra machine), the build fails along with all dependencies with long build times, such as PyTorch. Maybe we should consider disabling tests @bhipple @alexarice ?

danieldk added a commit to danieldk/nixpkgs that referenced this pull request Jul 30, 2020
oneDNN tests fail on some Hydra builders because they do not support SSE
4.2. Unfortunately, oneDNN does not seem to work without SSE 4.2, see
issues NixOS#93692 and NixOS#93747.
braack pushed a commit to braack/nixpkgs that referenced this pull request Oct 29, 2020
oneDNN tests fail on some Hydra builders because they do not support SSE
4.2. Unfortunately, oneDNN does not seem to work without SSE 4.2, see
issues NixOS#93692 and NixOS#93747.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants