Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kak auto pairs update #93933

Merged
merged 1 commit into from Nov 29, 2020
Merged

Kak auto pairs update #93933

merged 1 commit into from Nov 29, 2020

Conversation

@buffet
Copy link
Member

@buffet buffet commented Jul 26, 2020

Motivation for this change

Update (adds a few things, puts it into a module, ...).

Depends on #93931.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files [the plugin] (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@buffet
Copy link
Member Author

@buffet buffet commented Jul 26, 2020

Whoops, lemme get rid of that first commit...

@buffet
Copy link
Member Author

@buffet buffet commented Jul 26, 2020

Oh, and is there maybe a way to make this automatically depend on kak-prelude?

@FRidh
Copy link
Member

@FRidh FRidh commented Jul 26, 2020

@SuperSandro2000 SuperSandro2000 merged commit 36ff5e8 into NixOS:master Nov 29, 2020
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants