Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

singularity: 3.2.1 -> 3.6.1 #93971

Merged
merged 1 commit into from Aug 2, 2020
Merged

singularity: 3.2.1 -> 3.6.1 #93971

merged 1 commit into from Aug 2, 2020

Conversation

@jbedo
Copy link
Contributor

@jbedo jbedo commented Jul 27, 2020

Motivation for this change

Backporting this (712f1ee) to fix broken binary in 20.03. Update also resolves several security issues.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@jbedo
Copy link
Contributor Author

@jbedo jbedo commented Jul 27, 2020

Is this the right branch or should be against nixos-20.03?

@ckauhaus
Copy link
Contributor

@ckauhaus ckauhaus commented Jul 28, 2020

release-20.03 is correct

@ckauhaus ckauhaus linked an issue that may be closed by this pull request Jul 28, 2020
0 of 2 tasks complete
@ehmry ehmry merged commit 6967dc3 into NixOS:release-20.03 Aug 2, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1edaefd"; rev="1edaefd0bf5ff6e5a6debd12874566d14400de01"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1edaefd"; rev="1edaefd0bf5ff6e5a6debd12874566d14400de01"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1edaefd"; rev="1edaefd0bf5ff6e5a6debd12874566d14400de01"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1edaefd"; rev="1edaefd0bf5ff6e5a6debd12874566d14400de01"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1edaefd"; rev="1edaefd0bf5ff6e5a6debd12874566d14400de01"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1edaefd"; rev="1edaefd0bf5ff6e5a6debd12874566d14400de01"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="1edaefd"; rev="1edaefd0bf5ff6e5a6debd12874566d14400de01"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
singularity, singularity.passthru.tests on aarch64-linux Success
Details
singularity, singularity.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.