Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmusfm: 2018-10-11 -> 2020-07-23 #93974

Merged
merged 1 commit into from Nov 29, 2020
Merged

Conversation

@laMudri
Copy link
Contributor

@laMudri laMudri commented Jul 27, 2020

Motivation for this change

Minor update, which prevents cmusfm from building against curl 7.71.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@laMudri
Copy link
Contributor Author

@laMudri laMudri commented Jul 27, 2020

Maybe it's worth clarifying: when built against curl 7.71.0, cmusfm is broken. Against any other reasonable version is fine, whether or not the changes here are applied. nixpkgs has moved to curl 7.71.1, so you wouldn't expect any actual difference from these changes except if someone manually set the curl version to 7.71.0.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Result of nixpkgs-review pr 93974 run on x86_64-linux 1

1 package built:
  • cmusfm

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Nov 29, 2020

Result of nixpkgs-review pr 93974 run on x86_64-darwin 1

1 package built:
  • cmusfm

@SuperSandro2000 SuperSandro2000 merged commit b3c5739 into NixOS:master Nov 29, 2020
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants