Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inform6: init at 6.34-6.12.2 #94105

Merged
merged 1 commit into from Aug 1, 2020
Merged

inform6: init at 6.34-6.12.2 #94105

merged 1 commit into from Aug 1, 2020

Conversation

@ddelabru
Copy link
Contributor

ddelabru commented Jul 28, 2020

Motivation for this change

nixpkgs already has Inform 7, which is a lovely design system for creating interactive fiction (text adventures) using a natural language compiler and a rich IDE. However, underlying Inform 7 is a C-like language, Inform 6, which has a much simpler toolchain and its own compiler and standard libraries, which I have packaged for nix here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ddelabru
Copy link
Contributor Author

ddelabru commented Jul 28, 2020

@DavidGriffith, I welcome your thoughts as upstream maintainer for Inform 6.

@mbbx6spp, also interested if you have any feedback as the maintainer of the nix package for Inform 7.

@ddelabru ddelabru force-pushed the ddelabru:add-inform6 branch 2 times, most recently from d37b5b2 to 3c7cdbb Jul 28, 2020
@ddelabru
Copy link
Contributor Author

ddelabru commented Jul 29, 2020

@ofborg build inform6

@ddelabru
Copy link
Contributor Author

ddelabru commented Jul 29, 2020

/marvin opt-in

@marvin-mk2 marvin-mk2 bot added the marvin label Jul 29, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 29, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@ddelabru
Copy link
Contributor Author

ddelabru commented Jul 29, 2020

/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the needs_reviewer label Jul 29, 2020
@ddelabru ddelabru force-pushed the ddelabru:add-inform6 branch from 3c7cdbb to cac59b0 Jul 30, 2020
@Mic92
Copy link
Contributor

Mic92 commented Jul 30, 2020

/status needs_changes

@Mic92
Copy link
Contributor

Mic92 commented Jul 30, 2020

/status awaiting_changes

@ddelabru ddelabru force-pushed the ddelabru:add-inform6 branch from cac59b0 to 9a8250e Jul 30, 2020
nixpkgs already has Inform 7, which is a lovely design system for creating interactive fiction (text adventures) using a natural language compiler and a rich IDE. However, underlying Inform 7 is a C-like language, Inform 6, which has a much simpler toolchain and its own compiler and standard libraries, which I have packaged for nix here.
@ddelabru ddelabru force-pushed the ddelabru:add-inform6 branch from 9a8250e to 406509d Jul 30, 2020
@Mic92
Copy link
Contributor

Mic92 commented Jul 31, 2020

Are both projects still maintained?

@ddelabru
Copy link
Contributor Author

ddelabru commented Jul 31, 2020

@Mic92, yes, both projects are still maintained. Inform 6 is maintained by David Griffith, who doesn't appear to be active on GitHub and has moved all activity on Inform 6, frotz, and other projects over to gitlab.com.

@DavidGriffith
Copy link

DavidGriffith commented Jul 31, 2020

This looks okay to me.

@Mic92 Mic92 merged commit 0739f4b into NixOS:master Aug 1, 2020
17 checks passed
17 checks passed
tests
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="406509d"; rev="406509dcae055cf2cedc17168e07eef273cf41ed"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="406509d"; rev="406509dcae055cf2cedc17168e07eef273cf41ed"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="406509d"; rev="406509dcae055cf2cedc17168e07eef273cf41ed"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="406509d"; rev="406509dcae055cf2cedc17168e07eef273cf41ed"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="406509d"; rev="406509dcae055cf2cedc17168e07eef273cf41ed"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="406509d"; rev="406509dcae055cf2cedc17168e07eef273cf41ed"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="406509d"; rev="406509dcae055cf2cedc17168e07eef273cf41ed"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
inform6, inform6.passthru.tests on aarch64-linux Success
Details
inform6, inform6.passthru.tests on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.