Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scas: init at 0.4.6 #94165

Merged
merged 2 commits into from Aug 1, 2020
Merged

scas: init at 0.4.6 #94165

merged 2 commits into from Aug 1, 2020

Conversation

@siraben
Copy link
Contributor

siraben commented Jul 29, 2020

Motivation for this change

Add scas Z80 assembler

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@siraben siraben requested a review from sikmir Jul 30, 2020
@sikmir
sikmir approved these changes Jul 30, 2020
@siraben
Copy link
Contributor Author

siraben commented Jul 31, 2020

Ready to merge.

@Infinisil
Copy link
Member

Infinisil commented Aug 1, 2020

Please rebase the PR such that it has an initial commit that adds you as a maintainer and a second commit that adds the package

siraben added 2 commits Jul 29, 2020
Suggested changes
@siraben siraben force-pushed the siraben:scas branch from 76248d7 to a05e809 Aug 1, 2020
@Infinisil Infinisil merged commit 64a9b4b into NixOS:master Aug 1, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a05e809"; rev="a05e809205110cbf8d9c2286a8675dc5da5b9ed7"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a05e809"; rev="a05e809205110cbf8d9c2286a8675dc5da5b9ed7"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a05e809"; rev="a05e809205110cbf8d9c2286a8675dc5da5b9ed7"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a05e809"; rev="a05e809205110cbf8d9c2286a8675dc5da5b9ed7"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a05e809"; rev="a05e809205110cbf8d9c2286a8675dc5da5b9ed7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a05e809"; rev="a05e809205110cbf8d9c2286a8675dc5da5b9ed7"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="a05e809"; rev="a05e809205110cbf8d9c2286a8675dc5da5b9ed7"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
scas, scas.passthru.tests on aarch64-linux Success
Details
scas, scas.passthru.tests on x86_64-linux Success
Details
@siraben siraben deleted the siraben:scas branch Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.