Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgit: Init at 0.1.10 #94173

Closed
wants to merge 5 commits into from
Closed

mgit: Init at 0.1.10 #94173

wants to merge 5 commits into from

Conversation

@koozz
Copy link

@koozz koozz commented Jul 29, 2020

Motivation for this change

Commandline tool written in Rust by myself.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@koozz koozz requested a review from sikmir Jul 31, 2020
@sikmir
sikmir approved these changes Jul 31, 2020
@@ -9203,4 +9203,10 @@
github = "deifactor";
githubId = 30192992;
};
koozz = {

This comment has been minimized.

@timstott

timstott Aug 3, 2020
Contributor

🔡 Users are mostly inserted by alphabetical order. Could you find the next best spot for your username.

This comment has been minimized.

@koozz

koozz Aug 4, 2020
Author

I see, the last few were totally unordered and that made me think it was chronological. I've put myself in the ordered part now.

Copy link
Contributor

@timstott timstott left a comment

🙋 You need to add your package to pkgs/top-level/all-packages.nix

name = "Jan van den Berg";
email = "264371+koozz@users.noreply.github.com";
github = "koozz";
githubId = 264371;

This comment has been minimized.

@timstott

timstott Aug 4, 2020
Contributor

I believe the githubId is off by one 😬

curl -s https://api.github.com/users/koozz | jq .id
264372

This comment has been minimized.

@koozz

koozz Aug 4, 2020
Author

Weird, I found the noreply-email in my GitHub settings and copied that. Fixed it now.

@koozz koozz closed this Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.