Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enlightenment.efl: do not default to openjpeg 1 #94341

Merged
merged 1 commit into from Aug 1, 2020
Merged

Conversation

@romildo
Copy link
Contributor

romildo commented Jul 31, 2020

Motivation for this change

There is no apparent reason to use version 1 of openjpeg. Just use the default openjpeg, which currerntly is openjpeg-2.3.1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
It seems there is no reason to choose openjpeg-1. Just use the default
openjpeg, which currerntly is openjpeg-2.3.1.
@xeji
xeji approved these changes Aug 1, 2020
Copy link
Contributor

xeji left a comment

The openjpeg1 looks like something left over from an old bug that was fixed years ago:
https://phab.enlightenment.org/T3064

@xeji xeji merged commit 1e55e22 into NixOS:master Aug 1, 2020
17 checks passed
17 checks passed
enlightenment.efl, enlightenment.efl.passthru.tests on x86_64-darwin No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
enlightenment.efl, enlightenment.efl.passthru.tests on aarch64-linux Success
Details
enlightenment.efl, enlightenment.efl.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c4f9835"; rev="c4f98356c5cfb46df713224ac888e9467f9d7ea8"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c4f9835"; rev="c4f98356c5cfb46df713224ac888e9467f9d7ea8"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c4f9835"; rev="c4f98356c5cfb46df713224ac888e9467f9d7ea8"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c4f9835"; rev="c4f98356c5cfb46df713224ac888e9467f9d7ea8"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c4f9835"; rev="c4f98356c5cfb46df713224ac888e9467f9d7ea8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c4f9835"; rev="c4f98356c5cfb46df713224ac888e9467f9d7ea8"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="c4f9835"; rev="c4f98356c5cfb46df713224ac888e9467f9d7ea8"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@romildo romildo deleted the romildo:fix.efl branch Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.