Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc 8.8.3, 8.8.4, 8.10.1: disable profiled builds on aarch64 to avoid 2GB output limit (backport) #94372

Closed
wants to merge 2 commits into from

Conversation

@ggreif
Copy link
Contributor

ggreif commented Jul 31, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
domenkozar and others added 2 commits Jul 22, 2020
@ggreif
Copy link
Contributor Author

ggreif commented Jul 31, 2020

@GrahamcOfBorg build haskell.compiler.ghc883 haskell.compiler.ghc884 haskell.compiler.ghc8101

@ggreif
Copy link
Contributor Author

ggreif commented Jul 31, 2020

@domenkozar Is this a good idea? Can it break stuff on the release branch?

@domenkozar
Copy link
Member

domenkozar commented Jul 31, 2020

@ggreif
Copy link
Contributor Author

ggreif commented Jul 31, 2020

OfBorg is not particularly happy with aarch64...

@ggreif
Copy link
Contributor Author

ggreif commented Jul 31, 2020

@vcunat any idea why this is going wrong? Is GHC supported for aarch64 at all on the 20.03 release branch?

@vcunat
Copy link
Member

vcunat commented Aug 1, 2020

These ghc branches apparently aren't supported there. They're bootstrapped from 8.6.3-binary which does not have aarch64 version. On master that was solved by 5180ec3 (after 3c7ef6b).

@vcunat vcunat mentioned this pull request Aug 1, 2020
2 of 10 tasks complete
@ggreif
Copy link
Contributor Author

ggreif commented Aug 1, 2020

Thanks @vcunat, closing this PR as pointless then.

@ggreif ggreif closed this Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.