Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parity: 3.0.0 -> 3.0.1 and rename it to openethereum #94413

Open
wants to merge 1 commit into
base: master
from

Conversation

@enolan
Copy link
Contributor

enolan commented Aug 1, 2020

Motivation for this change

They've renamed the project to OpenEthereum, and released a new minor version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

rnhmjoj left a comment

To avoid users getting errors when updating Nixpkgs, you should always add an alias with the old name.
Add a definition in pkgs/top-level/aliases.nix with a date in a comment, please.

@enolan enolan force-pushed the enolan:update-parity branch from 0ba8377 to 9db2259 Aug 1, 2020
@enolan
Copy link
Contributor Author

enolan commented Aug 1, 2020

done :)

@rnhmjoj
rnhmjoj approved these changes Aug 1, 2020
Copy link
Contributor

rnhmjoj left a comment

Thank you.
It looks good to me, now but I'll wait for @mmahut before merging.

@akru
akru approved these changes Aug 1, 2020
Copy link
Contributor

akru left a comment

Looks good, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.