Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkerd: fix typo in package name #94414

Merged
merged 1 commit into from Aug 1, 2020
Merged

linkerd: fix typo in package name #94414

merged 1 commit into from Aug 1, 2020

Conversation

@kasimon
Copy link
Contributor

kasimon commented Aug 1, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@dasj19
dasj19 approved these changes Aug 1, 2020
Copy link
Contributor

dasj19 left a comment

Looks good.

@rnhmjoj
rnhmjoj approved these changes Aug 1, 2020
Copy link
Contributor

rnhmjoj left a comment

Thank you. Just one thing: can you rename the commit to linkerd: fix typo in package name?

@kasimon kasimon changed the title Fix typo in linkerd package name linkerd: fix typo in package name Aug 1, 2020
@kasimon
Copy link
Contributor Author

kasimon commented Aug 1, 2020

Thank you. Just one thing: can you rename the commit to linkerd: fix typo in package name?

Done :)

@rnhmjoj rnhmjoj merged commit 3c8063d into NixOS:master Aug 1, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb3843e"; rev="eb3843e1f6ac314b4c2ccbba2a1b8119cd156362"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb3843e"; rev="eb3843e1f6ac314b4c2ccbba2a1b8119cd156362"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb3843e"; rev="eb3843e1f6ac314b4c2ccbba2a1b8119cd156362"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb3843e"; rev="eb3843e1f6ac314b4c2ccbba2a1b8119cd156362"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb3843e"; rev="eb3843e1f6ac314b4c2ccbba2a1b8119cd156362"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb3843e"; rev="eb3843e1f6ac314b4c2ccbba2a1b8119cd156362"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="eb3843e"; rev="eb3843e1f6ac314b4c2ccbba2a1b8119cd156362"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Aug 1, 2020

Perfect, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.