Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: 78.0.2 -> 79.0, 68.10.0esr -> 68.11.0esr, 78.1.0esr [High security fixes] #94421

Merged
merged 4 commits into from Aug 1, 2020

Conversation

@taku0
Copy link
Contributor

taku0 commented Aug 1, 2020

Motivation for this change
  • High security fixes
  • Other updates and fixes.

https://www.mozilla.org/en-US/firefox/79.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2020-30/

https://www.mozilla.org/en-US/firefox/78.1.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2020-32/

https://www.mozilla.org/en-US/firefox/68.11.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2020-31/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ajs124
Copy link
Member

ajs124 commented Aug 1, 2020

Have you tested if all of these compile and work? I did these bumps a few days ago as well, but haven't gotten around to posting a PR because someone thought it would be a good idea to manipulate my build infrastructure for no good reason.

@taku0
Copy link
Contributor Author

taku0 commented Aug 1, 2020

Yes. All of 79.0, 78.1.0esr, and 68.11.0esr played YouTube video fine. https://www.youtube.com/user/firefoxchannel

@vcunat
vcunat approved these changes Aug 1, 2020
Copy link
Member

vcunat left a comment

I've been doing some testing; no issues so far.

@vcunat vcunat merged commit 508a5f4 into NixOS:master Aug 1, 2020
14 checks passed
14 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9f5628d"; rev="9f5628da432f5998665245923e2fc27b9b729474"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9f5628d"; rev="9f5628da432f5998665245923e2fc27b9b729474"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9f5628d"; rev="9f5628da432f5998665245923e2fc27b9b729474"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9f5628d"; rev="9f5628da432f5998665245923e2fc27b9b729474"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9f5628d"; rev="9f5628da432f5998665245923e2fc27b9b729474"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9f5628d"; rev="9f5628da432f5998665245923e2fc27b9b729474"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="9f5628d"; rev="9f5628da432f5998665245923e2fc27b9b729474"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
vcunat added a commit that referenced this pull request Aug 2, 2020
(cherry picked from commit 9f5628d)
Re-tested briefly on 20.03.  /cc PR #94421.
vcunat added a commit that referenced this pull request Aug 2, 2020
/cc the last PR #94421.  I ran each for a minute or two.
vcunat added a commit that referenced this pull request Aug 2, 2020
(cherry picked from commit 1d730e1)
/cc master PR #94421.
@vcunat
Copy link
Member

vcunat commented Aug 2, 2020

Backporting to release-20.03: I gave up on FF 79 (feel free to try), so for now I made it default to ESR 78 in ea0b3dd. In particular I noticed that ESR 68 is planned to end support a bit earlier than NixOS 20.03, so perhaps 78 will become the only compiled FF that we support in there in September.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.