Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc-{8.8.3, 8.8.4, 8.10.1}: fix typos #94430

Merged
merged 1 commit into from Aug 5, 2020

Conversation

@ggreif
Copy link
Contributor

ggreif commented Aug 1, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ggreif ggreif requested a review from cdepillabout as a code owner Aug 1, 2020
@ggreif
Copy link
Contributor Author

ggreif commented Aug 1, 2020

@domenkozar just a few is that slipped in.

There are no users of this flag, so I guess we are safe.

@ggreif ggreif force-pushed the ggreif:haskell-updates branch from 7b22f2d to 36577ef Aug 4, 2020
@ggreif
Copy link
Contributor Author

ggreif commented Aug 4, 2020

@GrahamcOfBorg build haskell.compiler.ghc883 haskell.compiler.ghc884 haskell.compiler.ghc8101

Copy link
Member

cdepillabout left a comment

I'd be happy to merge this in, especially if @domenkozar signs off.

@domenkozar domenkozar merged commit f0d9bf6 into NixOS:haskell-updates Aug 5, 2020
16 checks passed
16 checks passed
tests
Details
haskell.compiler.ghc8101, haskell.compiler.ghc883, haskell.compiler.ghc884 on aarch64-linux Timed out, unknown build status
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="36577ef"; rev="36577efda0a0bcb7917b971ab4ee493f040e0aa2"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="36577ef"; rev="36577efda0a0bcb7917b971ab4ee493f040e0aa2"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="36577ef"; rev="36577efda0a0bcb7917b971ab4ee493f040e0aa2"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="36577ef"; rev="36577efda0a0bcb7917b971ab4ee493f040e0aa2"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="36577ef"; rev="36577efda0a0bcb7917b971ab4ee493f040e0aa2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="36577ef"; rev="36577efda0a0bcb7917b971ab4ee493f040e0aa2"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="36577ef"; rev="36577efda0a0bcb7917b971ab4ee493f040e0aa2"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
haskell.compiler.ghc8101, haskell.compiler.ghc883, haskell.compiler.ghc884 on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.