Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postfix: 3.5.4 -> 3.5.6 #94457

Merged
merged 1 commit into from Aug 2, 2020
Merged

postfix: 3.5.4 -> 3.5.6 #94457

merged 1 commit into from Aug 2, 2020

Conversation

@dotlambda
Copy link
Member

dotlambda commented Aug 1, 2020

Motivation for this change

http://www.postfix.org/announcements/postfix-3.5.6.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@mweinelt
Copy link
Member

mweinelt commented Aug 1, 2020

@GrahamcOfBorg test postfix postfix-raise-smtpd-tls-security

@mweinelt
Copy link
Member

mweinelt commented Aug 1, 2020

Can you add passthru.tests? Done in #94484

@mweinelt
Copy link
Member

mweinelt commented Aug 1, 2020

The tests haven't been updated for 632104e. Done in #94484.

❯ nix-build nixos/tests/postfix.nix
error: 
Failed assertions:
- The option definition `services.postfix.sslCACert' in `<unknown-file>' no longer has any effect; please remove it.
services.postfix.sslCACert was replaced by services.postfix.tlsTrustedAuthorities. In case you intend that your server should validate requested client certificates use services.postfix.extraConfig.

(use '--show-trace' to show detailed location information)

The fix should be as simple as

diff --git a/nixos/tests/postfix.nix b/nixos/tests/postfix.nix
index 0d677427d76..9dbcf689122 100644
--- a/nixos/tests/postfix.nix
+++ b/nixos/tests/postfix.nix
@@ -1,4 +1,4 @@
-let 
+let
   certs = import ./common/acme/server/snakeoil-certs.nix;
 in
 import ./make-test-python.nix {
@@ -10,7 +10,7 @@ import ./make-test-python.nix {
       enable = true;
       enableSubmission = true;
       enableSubmissions = true;
-      sslCACert = certs.ca.cert;
+      tlsTrustedAuthorities = certs.ca.cert;
       sslCert = certs."acme.test".cert;
       sslKey = certs."acme.test".key;
       submissionsOptions = {
@mweinelt mweinelt merged commit 55f1aa3 into NixOS:master Aug 2, 2020
19 checks passed
19 checks passed
postfix, postfix.passthru.tests on x86_64-darwin No attempt
Details
tests.postfix, tests.postfix-raise-smtpd-tls-security on aarch64-linux No attempt
Details
tests.postfix, tests.postfix-raise-smtpd-tls-security on x86_64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91d6b55"; rev="91d6b557b5b442fe23279b6b766955473bf2c8f4"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91d6b55"; rev="91d6b557b5b442fe23279b6b766955473bf2c8f4"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91d6b55"; rev="91d6b557b5b442fe23279b6b766955473bf2c8f4"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91d6b55"; rev="91d6b557b5b442fe23279b6b766955473bf2c8f4"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91d6b55"; rev="91d6b557b5b442fe23279b6b766955473bf2c8f4"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91d6b55"; rev="91d6b557b5b442fe23279b6b766955473bf2c8f4"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="91d6b55"; rev="91d6b557b5b442fe23279b6b766955473bf2c8f4"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
postfix, postfix.passthru.tests on aarch64-linux Success
Details
postfix, postfix.passthru.tests on x86_64-linux Success
Details
@dotlambda dotlambda deleted the dotlambda:postfix-3.5.6 branch Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.