Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restinio: init at 0.6.8.1 #94460

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@doronbehar
Copy link
Contributor

doronbehar commented Aug 1, 2020

Motivation for this change

In my quest to package Jami, also requested at #83411 I learned that this is a dependency of several components of the project.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Copy link
Contributor

dasj19 left a comment

Builds well with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 94460". I don't know how to make use of this library though...

@doronbehar doronbehar force-pushed the doronbehar:package-jami branch from e6794d8 to bf455e7 Aug 2, 2020
@doronbehar
Copy link
Contributor Author

doronbehar commented Aug 2, 2020

Thanks for testing, but now I noticed I forgot to commit the all-packages.nix line addition, which means nixpkgs-review probably hasn't built anything for you :/.

@doronbehar
Copy link
Contributor Author

doronbehar commented Aug 3, 2020

The last push is an attempt to make the build succeed on Darwin, not like the latest: https://github.com/NixOS/nixpkgs/pull/94460/checks?check_run_id=937777778

@doronbehar doronbehar force-pushed the doronbehar:package-jami branch from b961cff to 93f5efc Aug 3, 2020
@doronbehar
Copy link
Contributor Author

doronbehar commented Aug 3, 2020

Can't fix the Darwin build, marking it as broken for Darwin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.