Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frotz: 2.44 -> 2.52 #94464

Merged
merged 1 commit into from Aug 6, 2020
Merged

frotz: 2.44 -> 2.52 #94464

merged 1 commit into from Aug 6, 2020

Conversation

@ddelabru
Copy link
Contributor

ddelabru commented Aug 1, 2020

Motivation for this change

As a bonus, this new derivation also adds unicode support, which the current nixpkgs build lacks.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@ddelabru
Copy link
Contributor Author

ddelabru commented Aug 1, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Aug 1, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 1, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the needs_reviewer label Aug 1, 2020
@ddelabru
Copy link
Contributor Author

ddelabru commented Aug 1, 2020

@nicknovitski, let me know what you think—the latest changes to frotz are on gitlab.com. Took me a while to get the derivation to properly link in ncursesw for Unicode support

@dasj19
dasj19 approved these changes Aug 2, 2020
Copy link
Contributor

dasj19 left a comment

Builds very quickly with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 94464". You can thick the 3rd box in the description.

The executable works just fine.

As a bonus, this new derivation also adds unicode support, which the current nixpkgs build lacks.
@ddelabru ddelabru force-pushed the ddelabru:update-frotz branch from aa41903 to 6771258 Aug 6, 2020
@ddelabru ddelabru mentioned this pull request Aug 6, 2020
5 of 10 tasks complete
@ddelabru
Copy link
Contributor Author

ddelabru commented Aug 6, 2020

@ofborg build frotz

@srhb srhb merged commit 679c084 into NixOS:master Aug 6, 2020
20 checks passed
20 checks passed
tests tests
Details
tests
Details
Evaluation Performance Report Evaluator Performance Report
Details
frotz on aarch64-linux Success
Details
frotz on x86_64-linux Success
Details
frotz, frotz.passthru.tests on aarch64-linux Success
Details
frotz, frotz.passthru.tests on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6771258"; rev="677125876e1ee623f2f79a799f791c1f40202052"; } ./pkgs/t
Details
grahamcofborg-eval-lib-tests nix-build --arg pkgs import ./. {} ./lib/tests/release.nix
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6771258"; rev="677125876e1ee623f2f79a799f791c1f40202052"; } ./nixos/
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6771258"; rev="677125876e1ee623f2f79a799f791c1f40202052"; } ./nixos/
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6771258"; rev="677125876e1ee623f2f79a799f791c1f40202052"; } ./nixos/
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6771258"; rev="677125876e1ee623f2f79a799f791c1f40202052"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6771258"; rev="677125876e1ee623f2f79a799f791c1f40202052"; } ./pkgs/t
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="6771258"; rev="677125876e1ee623f2f79a799f791c1f40202052"; } ./pkgs/t
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.